Limit inferred type sizes #2382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a notion of type "size" as a way to detect and avoid degenerate type inference cases. The examples found by the fuzzer can create large, complex types that result in hangs during type inference. Much like the type inference recursion limit, this size limit is a heuristic that is unlikely to be hit during normal use of the language but prevents crashes or hangs during extreme usage such as with generated code that incurs artificially large or deeply nested types. Fixes #2369
idavis
reviewed
May 8, 2025
idavis
approved these changes
May 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a notion of type "size" as a way to detect and avoid degenerate type inference cases. The examples found by the fuzzer can create large, complex types that result in hangs during type inference. Much like the type inference recursion limit, this size limit is a heuristic that is unlikely to be hit during normal use of the language but prevents crashes or hangs during extreme usage such as with generated code that incurs artificially large or deeply nested types.
Fixes #2369