Skip to content

Revert "Fix out-of-memory in typeck on nested Ty::Arrow" #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Revert "Fix out-of-memory in typeck on nested Ty::Arrow" #2359

merged 1 commit into from
May 1, 2025

Conversation

minestarks
Copy link
Member

Reverts #2336

To reduce unpredictability, I'm reverting this temporarily until we get the release out the door

@minestarks minestarks merged commit 34e4249 into main May 1, 2025
16 checks passed
@minestarks minestarks deleted the revert-2336-swernli/issue2302 branch May 1, 2025 16:42
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

Change in memory usage detected by benchmark.

Memory Report for 1f4654b

Test This Branch On Main Difference
compile core + standard lib 19941973 bytes 19150557 bytes 791416 bytes

swernli added a commit that referenced this pull request May 5, 2025
@swernli
Revert "Revert "Fix out-of-memory in typeck on nested Ty::Arrow" (#…
780d4ab 
…2359)"

Now that the release is complete, we can bring back this fix and let it marinate until the next release.
github-merge-queue bot pushed a commit that referenced this pull request May 5, 2025
@swernli
Revert "Revert "Fix out-of-memory in typeck on nested Ty::Arrow" (#…
a8ded9f 
…2359)" (#2362)

Now that the release is complete, we can bring back this fix and let it
marinate until the next release.

Closes #2302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billti billti Awaiting requested review from billti billti is a code owner

@idavis idavis Awaiting requested review from idavis idavis is a code owner

@ScottCarda-MS ScottCarda-MS Awaiting requested review from ScottCarda-MS ScottCarda-MS is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minestarks