Skip to content

Broadcasting and slicing updates #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
May 6, 2025
Merged

Broadcasting and slicing updates #2326

merged 42 commits into from
May 6, 2025

Conversation

orpuente-MS
Copy link
Contributor

@orpuente-MS orpuente-MS commented Apr 22, 2025 •
edited
Loading

This PR completes some postponed items from #2149 related to broadcasting, indexing, and arrays:

  • Gate call broadcasting.
  • Array declaration.
  • Multidimensional array indexing.
  • Multidimensional array assignment.
  • Array slicing.
  • Bitarray const evaluation.
  • Fixes issue with assign ops being compiled incorrectly.

@idavis idavis changed the title Qasm parser follow up Broadcasting and slicing updates Apr 22, 2025
@orpuente-MS orpuente-MS marked this pull request as ready for review April 24, 2025 21:23
@idavis idavis marked this pull request as draft April 29, 2025 18:07
@idavis idavis marked this pull request as ready for review May 2, 2025 21:27
@idavis idavis self-requested a review May 2, 2025 21:28
@orpuente-MS @swernli
Update compiler/qsc_qasm/src/semantic/lowerer.rs
856c460 
Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
swernli
swernli approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@orpuente-MS orpuente-MS enabled auto-merge May 6, 2025 21:15
@orpuente-MS orpuente-MS added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit d53d48f May 6, 2025
18 checks passed
@orpuente-MS orpuente-MS deleted the oscarpuente/qasm-follow-up branch May 6, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idavis idavis idavis approved these changes

@swernli swernli swernli approved these changes

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orpuente-MS @idavis @swernli