Supporting Arctic Backend Provider & Orderbook, Tick Data Example #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@luocy16 Please follow the instructions to format your code. Thanks |
you-n-g
reviewed
Dec 14, 2021
qlib/data/data.py
Outdated
| return_uri=False, | ||
| inst_processors=[], | ||
| ): | ||
| #print("disk_cache {}".format(disk_cache)) |
There was a problem hiding this comment.
Remove the useless code after testing.
you-n-g
reviewed
Dec 14, 2021
qlib/config.py
Outdated
| "mem_cache_expire": 60 * 60, | ||
| # memory cache space limit, default 5GB, only in used client | ||
| "mem_cache_space_limit": 1024 * 1024 * 1024 * 5, | ||
| "mem_cache_space_limit": 1024 * 1024 * 1024, |
There was a problem hiding this comment.
Why is it necessary to change the default memory size?
qlib/data/data.py
Outdated
|
|
||
| @staticmethod | ||
| def dataset_processor(instruments_d, column_names, start_time, end_time, freq, inst_processors=[]): | ||
| def dataset_processor(instruments_d, column_names, start_time, end_time, freq, type="qlib", inst_processors=[]): |
There was a problem hiding this comment.
Using constant string will be better.
you-n-g
reviewed
Dec 14, 2021
qlib/data/data.py
Outdated
| from .base import Feature | ||
| from .base import Feature, TFeature | ||
| from .ops import Operators | ||
| from .op_arctic import * |
There was a problem hiding this comment.
import * is not encouraged
qlib/data/data.py
Outdated
| try: | ||
| arctic = Arctic_Connection_List[0] | ||
| #print("arctic example: {}, task_index:{}".format(arctic, task_index)) | ||
| except Exception: |
There was a problem hiding this comment.
Please catch specific exception instead of except Exception:
you-n-g
reviewed
Jan 14, 2022
qlib/data/ops.py
Outdated
| elif self.func == 'ffill': | ||
| # TODO: | ||
| # Not sure why dropping duplicated element is necessary | ||
| series = series[~series.index.duplicated(keep='first')] |
There was a problem hiding this comment.
@luocy16 It's very kind of you if you could give any hints why ffill should be processed in such a special approach
you-n-g
changed the title
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
…crosoft#744) * change weight_decay & batchsize * del weight_decay * big weight_decay * mid weight_decay * small layer * 2 layer * full layer * no weight decay * divide into two data source * change parse field * delete some debug * add Toperator * new format of arctic * fix cache bug to arctic read * fix connection problem * add some operator * final version for arcitc * clear HZ cache * remove not used function * add topswrappers * successfully import data and run first test * A simpler version to support arctic * Successfully run all high-freq expressions * Black format and fix add docs * Add docs for download and test data * update scripts and docs * Add docs * fix bug * Refine docs * fix test bug * fix CI error * clean code Co-authored-by: bxdd <bxddream@gmail.com> Co-authored-by: wangwenxi.handsome <wangwenxi.handsome@gmail.com> Co-authored-by: Young <afe.young@gmail.com>
you-n-g
pushed a commit
to you-n-g/qlib
that referenced
this pull request
Aug 16, 2025
* rebase selection code * bug-free run: checkpoint selection and dynamic EDA loading * add prototypes of various selectors, to imp. and test later * fix EDA write bug * move selector to from proposal.py tp seletc.py * auto lint * fix line-too-long typos * aligh the design of "selection", rm extra instance check * make auto-lint * add non-trival selector: SOTAjump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes