Upgrade the rust version to 1.88 (#2583)

This PR upgrades the rust toolchain version from 1.86 to 1.88 across
multiple workflows and files. To make the upgrade possible, we had to
fix a linker issue and a wasm-config flag that changed in 1.87.

## Linker issue
Starting on rust 1.87, the Std doesn't link advapi32 on windows anymore.
So, C libraries that depend on it, like mimalloc, now need to link it
manually. [Link to the Rust
PR](rust-lang/rust#138233).

## wasm config flag
Rust 1.87 upgraded to LLVM 20, which enables bulk-memory by default.
Therefore, `wasm-opt` needs to be configured to expect this setting.
This behavior is document
[here](https://doc.rust-lang.org/rustc/platform-support/wasm32-unknown-unknown.html#enabled-webassembly-features).

---------

Co-authored-by: Bill Ticehurst <billti@microsoft.com>

Author: orpuente-MS

.ado/publish.yml

@@ -19,7 +19,7 @@ schedules:
 
 variables:
   CARGO_TERM_COLOR: always
-  RUST_TOOLCHAIN_VERSION: "1.86"
+  RUST_TOOLCHAIN_VERSION: "1.88"
 
 resources:
   repositories:

.github/workflows/bench-reports.yml

@@ -8,7 +8,7 @@ env:
   CARGO_TERM_COLOR: always
   NODE_VERSION: "20.18.2"
   PYTHON_VERSION: "3.11"
-  RUST_TOOLCHAIN_VERSION: "1.86"
+  RUST_TOOLCHAIN_VERSION: "1.88"
 
 jobs:
   runBenchmark:

.github/workflows/ci.yml

@@ -20,7 +20,7 @@ env:
   CARGO_TERM_COLOR: always
   NODE_VERSION: "20.18.2"
   PYTHON_VERSION: "3.11"
-  RUST_TOOLCHAIN_VERSION: "1.86"
+  RUST_TOOLCHAIN_VERSION: "1.88"
   RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
 
 jobs:

.github/workflows/copilot-setup-steps.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Setup rust toolchain
         uses: ./.github/actions/toolchains/rust
         with:
-          toolchain: "1.86"
+          toolchain: "1.88"
           components: rustfmt clippy
       - uses: actions/setup-python@v4
         with:

.github/workflows/memory_profile.yml

@@ -15,7 +15,7 @@ env:
   CARGO_TERM_COLOR: always
   NODE_VERSION: "20.18.2"
   PYTHON_VERSION: "3.11"
-  RUST_TOOLCHAIN_VERSION: "1.86"
+  RUST_TOOLCHAIN_VERSION: "1.88"
   RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
 
 jobs:

.github/workflows/publish-playground.yml

@@ -11,7 +11,7 @@ on:
 
 env:
   CARGO_TERM_COLOR: always
-  RUST_TOOLCHAIN_VERSION: "1.86"
+  RUST_TOOLCHAIN_VERSION: "1.88"
   RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
 
 # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages

prereqs.py

@@ -13,14 +13,14 @@
 import functools
 
 python_ver = (3, 11)  # Python support for Windows on ARM64 requires v3.11 or later
-rust_ver = (1, 86)  # Ensure Rust version 1.86 or later is installed
+rust_ver = (1, 88)  # Ensure Rust version 1.88 or later is installed
 node_ver = (
     20,
     18,
 )
 wasmpack_ver = (0, 12, 1)  # Latest tested wasm-pack version
-rust_fmt_ver = (1, 8, 0)  # Current version when Rust 1.86 shipped
-clippy_ver = (0, 1, 86)
+rust_fmt_ver = (1, 8, 0)  # Current version when Rust 1.88 shipped
+clippy_ver = (0, 1, 88)
 
 # Disable buffered output so that the log statements and subprocess output get interleaved in proper order
 print = functools.partial(print, flush=True)

source/allocator/mimalloc-sys/build.rs

@@ -23,6 +23,7 @@ fn main() -> Result<(), Box<dyn Error>> {
 // loads extra libraries, changes the name and path around, and does other things that are
 // difficult to handle. The cc crate is much simpler and more predictable.
 fn compile_mimalloc() {
+    let target = env::var("TARGET").expect("TARGET variable should exist");
     let mimalloc_vendor_dir = PathBuf::from("mimalloc");
 
     let mut build = cc::Build::new();
@@ -62,6 +63,14 @@ fn compile_mimalloc() {
     // turn off warnings from the mimalloc code
     build.cargo_warnings(false);
 
+    // Starting on rust 1.87, the Std doesn't link advapi32 on windows
+    // anymore. So, C libraries that depended on it, like mimalloc, now
+    // need to link it manually.
+    // Link to the Rust PR: <https://github.com/rust-lang/rust/pull/138233>
+    if target.contains("windows") {
+        println!("cargo:rustc-link-lib=advapi32");
+    }
+
     build.compile("mimalloc");
 }
 

source/compiler/qsc_rca/src/core.rs

@@ -1808,7 +1808,7 @@ impl<'a> Visitor<'a> for Analyzer<'a> {
         let is_test_callable = current_item_context
             .callable_context
             .as_ref()
-            .is_some_and(|f| f.attrs.iter().any(|attr| *attr == Attr::Test));
+            .is_some_and(|f| f.attrs.contains(&Attr::Test));
         match callable_impl {
             CallableImpl::Intrinsic => {
                 self.analyze_intrinsic_callable();

source/wasm/Cargo.toml

@@ -45,3 +45,14 @@ indoc = { workspace = true }
 
 [lints]
 workspace = true
+
+# Rust 1.87 upgraded to LLVM 20, which enables bulk-memory and non-trapping float by default.
+# (See https://github.com/rust-lang/rust/pull/137322)
+# Therefore, `wasm-opt` needs to be configured to expect this setting.
+# This behavior is document in:
+# <https://doc.rust-lang.org/rustc/platform-support/wasm32-unknown-unknown.html#enabled-webassembly-features>.
+[package.metadata.wasm-pack.profile.profiling]
+wasm-opt = ['-O', '--enable-bulk-memory', '--enable-nontrapping-float-to-int']
+
+[package.metadata.wasm-pack.profile.release]
+wasm-opt = ['-O', '--enable-bulk-memory', '--enable-nontrapping-float-to-int']