Hardcode exe returned for windows store envs #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jul 3, 2024
| exes: &Option<Vec<PathBuf>>, | ||
| ) -> Option<PathBuf> { | ||
| // For windows store, the exe should always be the one in the WindowsApps folder. | ||
| if *category == PythonEnvironmentCategory::WindowsStore { |
There was a problem hiding this comment.
Harcoded for windows store
There was a problem hiding this comment.
@karthiknadig /cc
DonJayamanne
force-pushed
the
fixWindowsStore
branch
from
5d84c00 to
ace156c
Compare
DonJayamanne
commented
Jul 3, 2024
| @@ -63,14 +63,15 @@ impl PotentialPython { | |||
| } else { | |||
| None | |||
| }) | |||
| .version(Some(self.version.clone())) | |||
| // We only have the partial version, no point returning bogus info. | |||
| // .version(Some(self.version.clone())) | |||
There was a problem hiding this comment.
Another change to never return bogus information (partial version != valid data)
And Pet does best effort to get valid/accurate data, or nothing at all.
There was a problem hiding this comment.
@karthiknadig /cc
chrmarti
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.