-
Notifications
You must be signed in to change notification settings - Fork 185
Separate macro definitions and add cppm files #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
922fe4b
Separate macro definitions and add cppm files
a2d41f6
Remove modules from msft_proxy target...
cfa416e
fix typo
9b652ea
Update to address problems mentioned in review...
4b7435c
Add some docs for the CMake script...
832a1a4
change `.cppm` to `.ixx` in doc
0cc1da1
(Try to) Use Ninja Generator instead.
4278202
Propagate `proxy_INCLUDE_DIR` to parent project ..
4a11c55
Update the doc test generator ...
eeaf225
Add back the compiler warning flags for doc tests
df626d1
Avoid creating empty dircetory ...
a50f457
Add "auto-generated" note for generated CMakeLists.txt
0a1d67f
Add common snippet to template system for future proof
4adbd37
Make PROXY_BUILDING_WITH_MODULE actually useful...
31c5151
Make PROXY_BUILDING_WITH_MODULE really really useful ...
e4664b8
Fix typo (issue #295)
11980c7
Disable module for older version of compilers
ee72d78
Switch back to Unix Makefiles for older compilers ...
3a0157d
Re-add "auto-generated" note for generated CMakeLists.txt ...
09ea107
resolve problems mentioned in code review ...
29fa01d
Removed line paddings in proxy.ixx
dcd89cc
revert docs/CMakeLists.txt
3982c61
Merge module test target with main test target
6360b7c
trailing EOL characters
02c5930
remove `target_compile_features` from `tests/CMakeLists.txt`
40302cf
remove trailing space
2f27ec9
remove `docs/cpp20_modules_support.cmake.in`
62f6c4d
Take CPM into consideration for C++ modules doc
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
|
||
#include <benchmark/benchmark.h> | ||
|
||
#include "proxy.h" | ||
#include <proxy/proxy.h> | ||
|
||
namespace { | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@PACKAGE_INIT@ | ||
mingxwa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
include("${CMAKE_CURRENT_LIST_DIR}/proxyTargets.cmake") | ||
|
||
set(proxy_INCLUDE_DIR "@PACKAGE_CMAKE_INSTALL_INCLUDEDIR@") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
|
||
if(NOT DEFINED proxy_INCLUDE_DIR) | ||
message(FATAL_ERROR "proxy_INCLUDE_DIR must be defined to use this script.") | ||
endif() | ||
|
||
message(STATUS "Declaring `msft_proxy::module` target for include path ${proxy_INCLUDE_DIR}") | ||
|
||
add_library(msft_proxy_module) | ||
set_target_properties( | ||
msft_proxy_module | ||
PROPERTIES | ||
SYSTEM TRUE | ||
EXCLUDE_FROM_ALL TRUE | ||
) | ||
|
||
add_library(msft_proxy::module ALIAS msft_proxy_module) | ||
target_sources(msft_proxy_module PUBLIC | ||
FILE_SET CXX_MODULES | ||
BASE_DIRS ${proxy_INCLUDE_DIR} | ||
FILES | ||
${proxy_INCLUDE_DIR}/proxy/proxy.ixx | ||
) | ||
target_compile_features(msft_proxy_module PUBLIC cxx_std_20) | ||
target_link_libraries(msft_proxy_module PUBLIC msft_proxy) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.