docs: add java snippets to the examples in guides #5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Mar 1, 2021
| // Using waitForNavigation with a callback prevents a race condition | ||
| // between clicking and waiting for a navigation. | ||
| page.waitForNavigation(() -> { // Waits for the next navigation | ||
| page.click("a"); // Triggers a navigation after a timeout |
There was a problem hiding this comment.
remove "aftter a timeout"
There was a problem hiding this comment.
it'd make the example useless as waitForNavigation would be redundant. I'll update the snippet separately for all langs
aslushnikov
reviewed
Mar 1, 2021
aslushnikov
approved these changes
Mar 1, 2021
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
Mar 1, 2021
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
Mar 1, 2021
yury-s
added a commit
that referenced
this pull request
Mar 1, 2021
This was referenced Mar 10, 2021
Merged
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.