fix(mcp): make verify tools work in iframes#39374
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Feb 24, 2026
Merged
fix(mcp): make verify tools work in iframes#39374pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
yury-s
approved these changes
Feb 23, 2026
| const locator = frame.getByRole(params.role as any, { name: params.accessibleName }); | ||
| if (await locator.count() > 0) { | ||
| const resolved = await locator._resolveForCode(); | ||
| response.addCode(`await expect(page.${resolved}).toBeVisible();`); |
Member
There was a problem hiding this comment.
should be resolved.first() in case of count > 1, otherwise it will throw
Member
Author
There was a problem hiding this comment.
Throwing would be intended behavior.
| const locator = frame.getByText(params.text).filter({ visible: true }); | ||
| if (await locator.count() > 0) { | ||
| const resolved = await locator._resolveForCode(); | ||
| response.addCode(`await expect(page.${resolved}).toBeVisible();`); |
pavelfeldman
force-pushed
the
frame_verify
branch
from
d498bac to
f9a6516
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"3 flaky36821 passed, 834 skipped Merge workflow run. |
Contributor
Test results for "MCP"1513 passed, 47 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright-mcp#1394