fix(testServer): add location to config loading errors #35710
+96
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
fix(testServer)--add-location-to-config-loading-errors
branch
2 times, most recently
from
183f0e5 to
83d9787
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Apr 23, 2025
| @@ -418,7 +418,17 @@ export class TestServerDispatcher implements TestServerInterface { | |||
| } | |||
| return { config }; | |||
| } catch (e) { | |||
| return { config: null, error: serializeError(e) }; | |||
| const error: reporterTypes.TestError = serializeError(e); | |||
| if (e.name === 'SyntaxError' && e.code === 'BABEL_PARSE_ERROR' && this._configLocation.resolvedConfigFile) { | |||
There was a problem hiding this comment.
We should find a better place for this. At least in utils. Don't we have such code somewhere already? Perhaps serializeError() should do that automatically and always set location?
mxschmitt
force-pushed
the
fix(testServer)--add-location-to-config-loading-errors
branch
from
83d9787 to
d7abd99
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
fix(testServer)--add-location-to-config-loading-errors
branch
from
d7abd99 to
d926aea
Compare
Test results for "tests 1"2 failed 6 flaky39093 passed, 803 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having e.g. a
SyntaxErroror athrow new Errorinside a config and using the VSCode extension, there was no error shown in the problems tab. This is because we didn't add thelocationproperty to theTestErrorwhich we sent back over to VSCode.Looks like it regressed when migrating to TestServer. Or a bit after it. When using CLI, we add the
locationproperty` here.