Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DeviceDescriptor not exposed #4507

Closed
Th-Os opened this issue Nov 20, 2020 · 2 comments
Closed

[BUG] DeviceDescriptor not exposed #4507

Th-Os opened this issue Nov 20, 2020 · 2 comments

Comments

@Th-Os
Copy link

Th-Os commented Nov 20, 2020

Context:

  • Playwright Version: 1.4.0
  • Operating System: Mac
  • Node.js version: v14.5.0
  • Browser: All
  • Extra: VSCode

Error message:
Module '"../../node_modules/playwright"' has no exported member 'DeviceDescriptor'.
import { DeviceDescriptor } from 'playwright';

Code Snippet

import { DeviceDescriptor } from 'playwright';

Describe the bug

Variants of above import, like import { DeviceDescriptor } from 'playwright/types/types'; or import { DeviceDescriptor } from 'playwright-core'; don't work either.

Could you please export this type?

@pavelfeldman
Copy link
Member

@JoelEinbinder should we generalize it to BrowserContextOptions?

@pavelfeldman
Copy link
Member

Closing this as a part of the triage, please feel free to file a new issue with additional details. Given the limited resource and a lot of requests, we need to fulfill most popular requests and at the same time keep our issue database manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants