Skip to content

[BUG] regression in killing web server process in 1.28.0 #18865

Closed

Description

Context:

  • Playwright Version: 1.28.0
  • Operating System: Linux and Mac
  • Node.js version: 16 and 18
  • Browser: All
  • Extra: Windows is okay

Code Snippet

You can run locally with:

npm create svelte@latest myapp (choose all defaults, but add playwright)
cd myapp
edit package.json to set playwright version to 1.28.0
npm install
npm test (run it twice)

Describe the bug

Server process is no longer being killed on Mac and Linux. It's possible we have some issue on our side, but it's not clear to me what that would be or how to debug it. I do experience this locally, but can kill the process with kill after Playwright fails to do so.

I see @aslushnikov sent a PR (#18220) affecting this section of code to address @rmunn's issue (#18209), which was later reverted (#18220). The issue was not reopened - should it be? Since that change was reverted, I'm not quite sure where else this might be coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions