From e8a33c4039e6035376957d9f335476241d99fa05 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 16 Mar 2021 23:27:39 -0700 Subject: [PATCH] feat(firefox): roll Firefox to r1237 (#5849) This patch rolls Firefox to r1237. Upstream firefox still struggles with crashes with certain videos: https://bugzilla.mozilla.org/show_bug.cgi?id=1697004 This PR also workarounds this crash by disabling webrender. References #5721 --- README.md | 4 ++-- browsers.json | 2 +- src/server/firefox/firefox.ts | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index f83b8c231bad7..182987279a653 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # 🎭 Playwright -[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://aka.ms/playwright-slack) [![Chromium version](https://img.shields.io/badge/chromium-90.0.4430.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home) [![Firefox version](https://img.shields.io/badge/firefox-86.0b10-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/) [![WebKit version](https://img.shields.io/badge/webkit-14.2-blue.svg?logo=safari)](https://webkit.org/) +[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://aka.ms/playwright-slack) [![Chromium version](https://img.shields.io/badge/chromium-90.0.4430.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home) [![Firefox version](https://img.shields.io/badge/firefox-87.0b5-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/) [![WebKit version](https://img.shields.io/badge/webkit-14.2-blue.svg?logo=safari)](https://webkit.org/) ## [Documentation](https://playwright.dev) | [API reference](https://playwright.dev/docs/api/class-playwright/) @@ -10,7 +10,7 @@ Playwright is a Node.js library to automate [Chromium](https://www.chromium.org/ | :--- | :---: | :---: | :---: | | Chromium 90.0.4430.0 | :white_check_mark: | :white_check_mark: | :white_check_mark: | | WebKit 14.2 | :white_check_mark: | :white_check_mark: | :white_check_mark: | -| Firefox 86.0b10 | :white_check_mark: | :white_check_mark: | :white_check_mark: | +| Firefox 87.0b5 | :white_check_mark: | :white_check_mark: | :white_check_mark: | Headless execution is supported for all the browsers on all platforms. Check out [system requirements](https://playwright.dev/docs/intro/#system-requirements) for details. diff --git a/browsers.json b/browsers.json index ae06bb075d918..4ce76261c9eb2 100644 --- a/browsers.json +++ b/browsers.json @@ -8,7 +8,7 @@ }, { "name": "firefox", - "revision": "1234", + "revision": "1237", "download": true }, { diff --git a/src/server/firefox/firefox.ts b/src/server/firefox/firefox.ts index 109a2d7a07e0e..15bfbc672e2b6 100644 --- a/src/server/firefox/firefox.ts +++ b/src/server/firefox/firefox.ts @@ -46,6 +46,8 @@ export class Firefox extends BrowserType { ...env, // On linux Juggler ships the libstdc++ it was linked against. LD_LIBRARY_PATH: `${path.dirname(executable)}:${process.env.LD_LIBRARY_PATH}`, + // @see https://github.com/microsoft/playwright/issues/5721 + MOZ_WEBRENDER: 0, } : env; }