From d5f5fbed5d22e40696991d6543da93364a68b4b2 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Fri, 3 Apr 2020 20:13:19 -0700 Subject: [PATCH] fix(webkit): fix non-mac screenshots w/ dsf --- package.json | 2 +- test/screenshot.spec.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 0369e1e120c71e..5b62a00851a07e 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "playwright": { "chromium_revision": "754895", "firefox_revision": "1069", - "webkit_revision": "1187" + "webkit_revision": "1188" }, "scripts": { "ctest": "cross-env BROWSER=chromium node test/test.js", diff --git a/test/screenshot.spec.js b/test/screenshot.spec.js index fba63f023660fd..e0059bfe4a44c8 100644 --- a/test/screenshot.spec.js +++ b/test/screenshot.spec.js @@ -217,7 +217,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO expect(screenshot).toBeInstanceOf(Buffer); } }); - it.fail(WEBKIT)('should work with device scale factor', async({browser, server}) => { + it('should work with device scale factor', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 }); const page = await context.newPage(); await page.goto(server.PREFIX + '/grid.html'); @@ -394,7 +394,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO expect(screenshot).toBeGolden('screenshot-element-mobile.png'); await context.close(); }); - it.fail(WEBKIT && LINUX).skip(FFOX)('should work with device scale factor', async({browser, server}) => { + it.skip(FFOX)('should work with device scale factor', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 }); const page = await context.newPage(); await page.goto(server.PREFIX + '/grid.html');