cherry-pick(#32880): chore: unflake 'should record'

microsoft · Sep 30, 2024 · 7155356 · 7155356
1 parent d3e38c3
commit 7155356
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/playwright-core/src/server/recorder/recorderCollection.ts b/packages/playwright-core/src/server/recorder/recorderCollection.ts
@@ -126,6 +126,8 @@ export class RecorderCollection extends EventEmitter {
   }
 
   private _fireChange() {
+    if (!this._enabled)
+      return;
     this.emit('change', collapseActions(this._actions));
   }
 }
diff --git a/tests/library/debug-controller.spec.ts b/tests/library/debug-controller.spec.ts
@@ -188,9 +188,9 @@ test('test', async ({ page }) => {
   await page.getByRole('button', { name: 'Submit' }).click();
 });`
   });
-  const length = events.length;
   // No events after mode disabled
   await backend.setRecorderMode({ mode: 'none' });
+  const length = events.length;
   await page.getByRole('button').click();
   expect(events).toHaveLength(length);
 });