chore: add missing await annotate floating promises

src/browserServerImpl.ts

@@ -34,6 +34,7 @@ import { BrowserContext, Video } from './server/browserContext';
 import { StreamDispatcher } from './dispatchers/streamDispatcher';
 import { ProtocolLogger } from './server/types';
 import { CallMetadata, internalCallMetadata, SdkObject } from './server/instrumentation';
+import { debugLogger } from './utils/debugLogger';
 
 export class BrowserServerLauncherImpl implements BrowserServerLauncher {
   private _browserType: BrowserType;
@@ -116,7 +117,7 @@ export class BrowserServerImpl extends EventEmitter implements BrowserServer {
         socket.send(JSON.stringify(message));
     };
     socket.on('message', (message: string) => {
-      connection.dispatch(JSON.parse(Buffer.from(message).toString()));
+      connection.dispatch(JSON.parse(Buffer.from(message).toString())).catch(e => debugLogger.log('error', e));
     });
     socket.on('error', () => {});
     const selectors = new Selectors();

src/cli/cli.ts

@@ -39,7 +39,7 @@ program
 
 commandWithOpenOptions('open [url]', 'open page in browser specified via -b, --browser', [])
     .action(function(url, command) {
-      open(command, url, language());
+      open(command, url, language()).catch(logErrorAndExit);
     })
     .on('--help', function() {
       console.log('');
@@ -54,7 +54,7 @@ commandWithOpenOptions('codegen [url]', 'open page and generate code for user ac
       ['-o, --output <file name>', 'saves the generated script to a file'],
       ['--target <language>', `language to use, one of javascript, python, python-async, csharp`, language()],
     ]).action(function(url, command) {
-  codegen(command, url, command.target, command.output);
+  codegen(command, url, command.target, command.output).catch(logErrorAndExit);
 }).on('--help', function() {
   console.log('');
   console.log('Examples:');
@@ -122,7 +122,7 @@ const browsers = [
 for (const {alias, name, type} of browsers) {
   commandWithOpenOptions(`${alias} [url]`, `open page in ${name}`, [])
       .action(function(url, command) {
-        open({ ...command, browser: type }, url, command.target);
+        open({ ...command, browser: type }, url, command.target).catch(logErrorAndExit);
       }).on('--help', function() {
         console.log('');
         console.log('Examples:');
@@ -137,7 +137,7 @@ commandWithOpenOptions('screenshot <url> <filename>', 'capture a page screenshot
       ['--wait-for-timeout <timeout>', 'wait for timeout in milliseconds before taking a screenshot'],
       ['--full-page', 'whether to take a full page screenshot (entire scrollable area)'],
     ]).action(function(url, filename, command) {
-  screenshot(command, command, url, filename);
+  screenshot(command, command, url, filename).catch(logErrorAndExit);
 }).on('--help', function() {
   console.log('');
   console.log('Examples:');
@@ -150,7 +150,7 @@ commandWithOpenOptions('pdf <url> <filename>', 'save page as pdf',
       ['--wait-for-selector <selector>', 'wait for given selector before saving as pdf'],
       ['--wait-for-timeout <timeout>', 'wait for given timeout in milliseconds before saving as pdf'],
     ]).action(function(url, filename, command) {
-  pdf(command, command, url, filename);
+  pdf(command, command, url, filename).catch(logErrorAndExit);
 }).on('--help', function() {
   console.log('');
   console.log('Examples:');
@@ -164,7 +164,7 @@ if (process.env.PWTRACE) {
       .option('--resources <dir>', 'load resources from shared folder')
       .description('Show trace viewer')
       .action(function(trace, command) {
-        showTraceViewer(trace, command.resources);
+        showTraceViewer(trace, command.resources).catch(logErrorAndExit);
       }).on('--help', function() {
         console.log('');
         console.log('Examples:');
@@ -179,7 +179,7 @@ if (process.argv[2] === 'run-driver')
 else if (process.argv[2] === 'print-api-json')
   printApiJson();
 else if (process.argv[2] === 'launch-server')
-  launchBrowserServer(process.argv[3], process.argv[4]);
+  launchBrowserServer(process.argv[3], process.argv[4]).catch(logErrorAndExit);
 else
   program.parse(process.argv);
 
@@ -442,6 +442,11 @@ function validateOptions(options: Options) {
   }
 }
 
+function logErrorAndExit(e: Error) {
+  console.error(e);
+  process.exit(1);
+}
+
 function language(): string {
   return process.env.PW_CLI_TARGET_LANG || 'javascript';
 }

src/client/android.ts

@@ -46,7 +46,7 @@ export class Android extends ChannelOwner<channels.AndroidChannel, channels.Andr
 
   setDefaultTimeout(timeout: number) {
     this._timeoutSettings.setDefaultTimeout(timeout);
-    this._channel.setDefaultTimeoutNoReply({ timeout });
+    void this._channel.setDefaultTimeoutNoReply({ timeout });
   }
 
   async devices(): Promise<AndroidDevice[]> {
@@ -90,7 +90,7 @@ export class AndroidDevice extends ChannelOwner<channels.AndroidDeviceChannel, c
 
   setDefaultTimeout(timeout: number) {
     this._timeoutSettings.setDefaultTimeout(timeout);
-    this._channel.setDefaultTimeoutNoReply({ timeout });
+    void this._channel.setDefaultTimeoutNoReply({ timeout });
   }
 
   serial(): string {

src/client/browserContext.ts

@@ -87,17 +87,17 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel,
     const func = this._bindings.get(bindingCall._initializer.name);
     if (!func)
       return;
-    bindingCall.call(func);
+    await bindingCall.call(func);
   }
 
   setDefaultNavigationTimeout(timeout: number) {
     this._timeoutSettings.setDefaultNavigationTimeout(timeout);
-    this._channel.setDefaultNavigationTimeoutNoReply({ timeout });
+    void this._channel.setDefaultNavigationTimeoutNoReply({ timeout });
   }
 
   setDefaultTimeout(timeout: number) {
     this._timeoutSettings.setDefaultTimeout(timeout);
-    this._channel.setDefaultTimeoutNoReply({ timeout });
+    void this._channel.setDefaultTimeoutNoReply({ timeout });
   }
 
   browser(): Browser | null {
@@ -238,7 +238,7 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel,
     });
   }
 
-  async _onClose() {
+  _onClose() {
     if (this._browser)
       this._browser._contexts.delete(this);
     this.emit(Events.BrowserContext.Close, this);

src/client/page.ts

@@ -186,10 +186,10 @@ export class Page extends ChannelOwner<channels.PageChannel, channels.PageInitia
   async _onBinding(bindingCall: BindingCall) {
     const func = this._bindings.get(bindingCall._initializer.name);
     if (func) {
-      bindingCall.call(func);
+      await bindingCall.call(func);
       return;
     }
-    this._browserContext._onBinding(bindingCall);
+    await this._browserContext._onBinding(bindingCall);
   }
 
   _onWorker(worker: Worker): void {
@@ -239,12 +239,12 @@ export class Page extends ChannelOwner<channels.PageChannel, channels.PageInitia
 
   setDefaultNavigationTimeout(timeout: number) {
     this._timeoutSettings.setDefaultNavigationTimeout(timeout);
-    this._channel.setDefaultNavigationTimeoutNoReply({ timeout });
+    void this._channel.setDefaultNavigationTimeoutNoReply({ timeout });
   }
 
   setDefaultTimeout(timeout: number) {
     this._timeoutSettings.setDefaultTimeout(timeout);
-    this._channel.setDefaultTimeoutNoReply({ timeout });
+    void this._channel.setDefaultTimeoutNoReply({ timeout });
   }
 
   video(): Video | null {
@@ -617,29 +617,29 @@ export class Page extends ChannelOwner<channels.PageChannel, channels.PageInitia
 
   on(event: string | symbol, listener: Listener): this {
     if (event === Events.Page.FileChooser && !this.listenerCount(event))
-      this._channel.setFileChooserInterceptedNoReply({ intercepted: true });
+      this._channel.setFileChooserInterceptedNoReply({ intercepted: true }).catch(e => {});
     super.on(event, listener);
     return this;
   }
 
   addListener(event: string | symbol, listener: Listener): this {
     if (event === Events.Page.FileChooser && !this.listenerCount(event))
-      this._channel.setFileChooserInterceptedNoReply({ intercepted: true });
+      this._channel.setFileChooserInterceptedNoReply({ intercepted: true }).catch(e => {});
     super.addListener(event, listener);
     return this;
   }
 
   off(event: string | symbol, listener: Listener): this {
     super.off(event, listener);
     if (event === Events.Page.FileChooser && !this.listenerCount(event))
-      this._channel.setFileChooserInterceptedNoReply({ intercepted: false });
+      this._channel.setFileChooserInterceptedNoReply({ intercepted: false }).catch(e => {});
     return this;
   }
 
   removeListener(event: string | symbol, listener: Listener): this {
     super.removeListener(event, listener);
     if (event === Events.Page.FileChooser && !this.listenerCount(event))
-      this._channel.setFileChooserInterceptedNoReply({ intercepted: false });
+      this._channel.setFileChooserInterceptedNoReply({ intercepted: false }).catch(e => {});
     return this;
   }
 

src/remote/playwrightServer.ts

@@ -48,11 +48,11 @@ export class PlaywrightServer {
       ws.on('message', message => dispatcherConnection.dispatch(JSON.parse(message.toString())));
       ws.on('close', () => {
         debugLog('Client closed');
-        this._onDisconnect();
+        this._onDisconnect().catch(debugLog);
       });
       ws.on('error', error => {
         debugLog('Client error ' + error);
-        this._onDisconnect();
+        this._onDisconnect().catch(debugLog);
       });
       dispatcherConnection.onmessage = message => ws.send(JSON.stringify(message));
       new PlaywrightDispatcher(dispatcherConnection.rootDispatcher(), createPlaywright());

src/server/android/android.ts

@@ -176,7 +176,7 @@ export class AndroidDevice extends SdkObject {
       await this.installApk(await readFileAsync(require.resolve(`../../../bin/${file}`)));
 
     debug('pw:android')('Starting the new driver');
-    this.shell('am instrument -w com.microsoft.playwright.androiddriver.test/androidx.test.runner.AndroidJUnitRunner');
+    this.shell('am instrument -w com.microsoft.playwright.androiddriver.test/androidx.test.runner.AndroidJUnitRunner').catch(e => debug('pw:android')(e));
     const socket = await this._waitForLocalAbstract('playwright_android_driver_socket');
     const transport = new Transport(socket, socket, socket, 'be');
     transport.onmessage = message => {

src/server/android/backendAdb.ts

@@ -126,7 +126,7 @@ class BufferedSocketWrapper extends EventEmitter implements SocketBackend {
       this._isClosed = true;
       if (this._notifyReader)
         this._notifyReader();
-      this.close();
+      void this.close();
       this.emit('close');
     });
     this._socket.on('error', error => this.emit('error', error));

src/server/browser.ts

@@ -88,15 +88,15 @@ export abstract class Browser extends SdkObject {
     const download = this._downloads.get(uuid);
     if (!download)
       return;
-    download._reportFinished(error);
+    download._reportFinished(error).catch(e => {});
     this._downloads.delete(uuid);
   }
 
   _videoStarted(context: BrowserContext, videoId: string, path: string, pageOrError: Promise<Page | Error>) {
     const video = new Video(context, videoId, path);
     this._idToVideo.set(videoId, video);
     context.emit(BrowserContext.Events.VideoStarted, video);
-    pageOrError.then(pageOrError => {
+    void pageOrError.then(pageOrError => {
       if (pageOrError instanceof Page)
         pageOrError.videoStarted(video);
     });
@@ -105,7 +105,7 @@ export abstract class Browser extends SdkObject {
   _videoFinished(videoId: string) {
     const video = this._idToVideo.get(videoId)!;
     this._idToVideo.delete(videoId);
-    video._finish();
+    void video._finish();
   }
 
   _didClose() {

src/server/chromium/crBrowser.ts

@@ -28,6 +28,7 @@ import { readProtocolStream } from './crProtocolHelper';
 import { Protocol } from './protocol';
 import { CRExecutionContext } from './crExecutionContext';
 import { CRDevTools } from './crDevTools';
+import { debugLogger } from '../../utils/debugLogger';
 
 export class CRBrowser extends Browser {
   readonly _connection: CRConnection;
@@ -135,15 +136,15 @@ export class CRBrowser extends Browser {
     }
 
     if (targetInfo.type === 'other' && targetInfo.url.startsWith('devtools://devtools') && this._devtools) {
-      this._devtools.install(session);
+      this._devtools.install(session).catch(e => debugLogger.log('error', e));
       return;
     }
 
     if (targetInfo.type === 'other' || !context) {
       if (waitingForDebugger) {
         // Ideally, detaching should resume any target, but there is a bug in the backend.
-        session._sendMayFail('Runtime.runIfWaitingForDebugger').then(() => {
-          this._session._sendMayFail('Target.detachFromTarget', { sessionId });
+        void session._sendMayFail('Runtime.runIfWaitingForDebugger').then(() => {
+          return this._session._sendMayFail('Target.detachFromTarget', { sessionId });
         });
       }
       return;
@@ -156,7 +157,7 @@ export class CRBrowser extends Browser {
     if (targetInfo.type === 'background_page') {
       const backgroundPage = new CRPage(session, targetInfo.targetId, context, null, false);
       this._backgroundPages.set(targetInfo.targetId, backgroundPage);
-      backgroundPage.pageOrError().then(pageOrError => {
+      void backgroundPage.pageOrError().then(pageOrError => {
         if (pageOrError instanceof Page)
           context!.emit(CRBrowserContext.CREvents.BackgroundPage, backgroundPage._page);
       });
@@ -167,7 +168,7 @@ export class CRBrowser extends Browser {
       const opener = targetInfo.openerId ? this._crPages.get(targetInfo.openerId) || null : null;
       const crPage = new CRPage(session, targetInfo.targetId, context, opener, true);
       this._crPages.set(targetInfo.targetId, crPage);
-      crPage._page.reportAsNew();
+      void crPage._page.reportAsNew();
       return;
     }
 

src/server/chromium/crConnection.ts

@@ -100,7 +100,7 @@ export class CRConnection extends EventEmitter {
     for (const session of this._sessions.values())
       session._onClosed(browserDisconnectedLogs);
     this._sessions.clear();
-    Promise.resolve().then(() => this.emit(ConnectionEvents.Disconnected));
+    void Promise.resolve().then(() => this.emit(ConnectionEvents.Disconnected));
   }
 
   close() {
@@ -187,7 +187,7 @@ export class CRSession extends EventEmitter {
         callback.resolve(object.result);
     } else {
       assert(!object.id);
-      Promise.resolve().then(() => {
+      void Promise.resolve().then(() => {
         if (this._eventListener)
           this._eventListener(object.method!, object.params);
         this.emit(object.method!, object.params);
@@ -211,7 +211,7 @@ export class CRSession extends EventEmitter {
       callback.reject(rewriteErrorMessage(callback.error, `Protocol error (${callback.method}): ` + errorMessage));
     this._callbacks.clear();
     this._connection = null;
-    Promise.resolve().then(() => this.emit(CRSessionEvents.Disconnected));
+    void Promise.resolve().then(() => this.emit(CRSessionEvents.Disconnected));
   }
 }
 

src/server/chromium/crCoverage.ts

@@ -90,7 +90,7 @@ class JSCoverage {
   }
 
   _onDebuggerPaused() {
-    this._client.send('Debugger.resume');
+    this._client.send('Debugger.resume').catch(() => {});
   }
 
   _onExecutionContextsCleared() {

src/server/chromium/crNetworkManager.ts

@@ -152,23 +152,23 @@ export class CRNetworkManager {
       this._attemptedAuthentications.add(event.requestId);
     }
     const {username, password} = this._credentials || {username: undefined, password: undefined};
-    this._client._sendMayFail('Fetch.continueWithAuth', {
+    void this._client._sendMayFail('Fetch.continueWithAuth', {
       requestId: event.requestId,
       authChallengeResponse: { response, username, password },
     });
   }
 
   _onRequestPaused(workerFrame: frames.Frame | undefined, event: Protocol.Fetch.requestPausedPayload) {
     if (!this._userRequestInterceptionEnabled && this._protocolRequestInterceptionEnabled) {
-      this._client._sendMayFail('Fetch.continueRequest', {
+      void this._client._sendMayFail('Fetch.continueRequest', {
         requestId: event.requestId
       });
     }
     if (!event.networkId) {
       // Fetch without networkId means that request was not recongnized by inspector, and
       // it will never receive Network.requestWillBeSent. Most likely, this is an internal request
       // that we can safely fail.
-      this._client._sendMayFail('Fetch.failRequest', {
+      void this._client._sendMayFail('Fetch.failRequest', {
         requestId: event.requestId,
         errorReason: 'Aborted',
       });
@@ -228,7 +228,7 @@ export class CRNetworkManager {
       ];
       if (requestHeaders['Access-Control-Request-Headers'])
         responseHeaders.push({ name: 'Access-Control-Allow-Headers', value: requestHeaders['Access-Control-Request-Headers'] });
-      this._client._sendMayFail('Fetch.fulfillRequest', {
+      void this._client._sendMayFail('Fetch.fulfillRequest', {
         requestId: requestPausedEvent.requestId,
         responseCode: 204,
         responsePhrase: network.STATUS_TEXTS['204'],
@@ -240,7 +240,7 @@ export class CRNetworkManager {
 
     if (!frame) {
       if (requestPausedEvent)
-        this._client._sendMayFail('Fetch.continueRequest', { requestId: requestPausedEvent.requestId });
+        void this._client._sendMayFail('Fetch.continueRequest', { requestId: requestPausedEvent.requestId });
       return;
     }
 
@@ -249,7 +249,7 @@ export class CRNetworkManager {
       allowInterception = false;
       // We do not support intercepting redirects.
       if (requestPausedEvent)
-        this._client._sendMayFail('Fetch.continueRequest', { requestId: requestPausedEvent.requestId });
+        void this._client._sendMayFail('Fetch.continueRequest', { requestId: requestPausedEvent.requestId });
     }
     const isNavigationRequest = requestWillBeSentEvent.requestId === requestWillBeSentEvent.loaderId && requestWillBeSentEvent.type === 'Document';
     const documentId = isNavigationRequest ? requestWillBeSentEvent.loaderId : undefined;