Skip to content

Commit 6bbc09c

Browse files
authored
chore: show channel name in trace viewer metadata (#26987)
Fixes #26986
1 parent 5811d65 commit 6bbc09c

File tree

6 files changed

+7
-0
lines changed

6 files changed

+7
-0
lines changed

packages/playwright-core/src/server/trace/recorder/tracing.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps
109109
this._snapshotter = new Snapshotter(context, this);
110110
assert(tracesDir, 'tracesDir must be specified for BrowserContext');
111111
this._contextCreatedEvent.browserName = context._browser.options.name;
112+
this._contextCreatedEvent.channel = context._browser.options.channel;
112113
this._contextCreatedEvent.options = context._options;
113114
}
114115
}

packages/trace-viewer/src/entries.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export type ContextEntry = {
2424
startTime: number;
2525
endTime: number;
2626
browserName: string;
27+
channel?: string;
2728
platform?: string;
2829
wallTime?: number;
2930
sdkLanguage?: Language;

packages/trace-viewer/src/traceModel.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ export class TraceModel {
156156
this._version = event.version;
157157
contextEntry.isPrimary = true;
158158
contextEntry.browserName = event.browserName;
159+
contextEntry.channel = event.channel;
159160
contextEntry.title = event.title;
160161
contextEntry.platform = event.platform;
161162
contextEntry.wallTime = event.wallTime;

packages/trace-viewer/src/ui/metadataView.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export const MetadataView: React.FunctionComponent<{
3030
<div className='call-line'>duration:<span className='call-value number' title={msToString(model.endTime - model.startTime)}>{msToString(model.endTime - model.startTime)}</span></div>
3131
<div className='call-section'>Browser</div>
3232
<div className='call-line'>engine:<span className='call-value string' title={model.browserName}>{model.browserName}</span></div>
33+
{model.channel && <div className='call-line'>channel:<span className='call-value string' title={model.channel}>{model.channel}</span></div>}
3334
{model.platform && <div className='call-line'>platform:<span className='call-value string' title={model.platform}>{model.platform}</span></div>}
3435
{model.options.userAgent && <div className='call-line'>user agent:<span className='call-value datetime' title={model.options.userAgent}>{model.options.userAgent}</span></div>}
3536
<div className='call-section'>Viewport</div>

packages/trace-viewer/src/ui/modelUtil.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export class MultiTraceModel {
5151
readonly startTime: number;
5252
readonly endTime: number;
5353
readonly browserName: string;
54+
readonly channel?: string;
5455
readonly platform?: string;
5556
readonly wallTime?: number;
5657
readonly title?: string;
@@ -72,6 +73,7 @@ export class MultiTraceModel {
7273

7374
this.browserName = primaryContext?.browserName || '';
7475
this.sdkLanguage = primaryContext?.sdkLanguage;
76+
this.channel = primaryContext?.channel;
7577
this.testIdAttributeName = primaryContext?.testIdAttributeName;
7678
this.platform = primaryContext?.platform || '';
7779
this.title = primaryContext?.title || '';

packages/trace/src/trace.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export type ContextCreatedTraceEvent = {
3434
version: number,
3535
type: 'context-options',
3636
browserName: string,
37+
channel?: string,
3738
platform: string,
3839
wallTime: number,
3940
title?: string,

0 commit comments

Comments
 (0)