From 2926d33a478bbf4e8e80a3ff165d70b24c828465 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 22 Apr 2020 00:07:02 -0700 Subject: [PATCH] test: disable flaky firefox tests (#1912) --- test/fixtures.spec.js | 5 ++++- test/mouse.spec.js | 5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/fixtures.spec.js b/test/fixtures.spec.js index eeaa2d0a81e43..074e4a7422391 100644 --- a/test/fixtures.spec.js +++ b/test/fixtures.spec.js @@ -124,7 +124,10 @@ describe('Fixtures', function() { // TODO: ideally, we would expect the SIGKILL on the browser from // force kill, but that's racy with sending two signals. }); - it.slow()('should kill the browser on SIGTERM + SIGINT', async state => { + // TODO: flaky! + // - firefox: https://github.com/microsoft/playwright/pull/1911/checks?check_run_id=607148951 + // - chromium: https://travis-ci.com/github/microsoft/playwright/builds/161356178 + it.slow().fail((FFOX || CHROMIUM) && LINUX)('should kill the browser on SIGTERM + SIGINT', async state => { const result = await testSignal(state, child => { process.kill(child.pid, 'SIGTERM'); process.kill(child.pid, 'SIGINT'); diff --git a/test/mouse.spec.js b/test/mouse.spec.js index a6cb2ca30dd32..071890fee3454 100644 --- a/test/mouse.spec.js +++ b/test/mouse.spec.js @@ -15,7 +15,7 @@ * limitations under the License. */ -const {FFOX, CHROMIUM, WEBKIT, MAC} = require('./utils').testOptions(browserType); +const {FFOX, CHROMIUM, WEBKIT, MAC, WIN} = require('./utils').testOptions(browserType); function dimensions() { const rect = document.querySelector('textarea').getBoundingClientRect(); @@ -28,7 +28,8 @@ function dimensions() { } describe('Mouse', function() { - it('should click the document', async({page, server}) => { + // Occasionally times out on FFOX on Windows: https://github.com/microsoft/playwright/pull/1911/checks?check_run_id=607149016 + it.fail(FFOX && WIN)('should click the document', async({page, server}) => { await page.evaluate(() => { window.clickPromise = new Promise(resolve => { document.addEventListener('click', event => {