chore: bump TypeScript to v5.5 (#31532)

Author: mxschmitt

package-lock.json

@@ -70,9 +70,9 @@
     "@types/resize-observer-browser": "^0.1.7",
     "@types/ws": "^8.5.3",
     "@types/xml2js": "^0.4.9",
-    "@typescript-eslint/eslint-plugin": "^6.13.2",
-    "@typescript-eslint/parser": "^6.13.2",
-    "@typescript-eslint/utils": "^6.13.2",
+    "@typescript-eslint/eslint-plugin": "^7.15.0",
+    "@typescript-eslint/parser": "^7.15.0",
+    "@typescript-eslint/utils": "^7.15.0",
     "@vitejs/plugin-basic-ssl": "^1.1.0",
     "@vitejs/plugin-react": "^4.2.1",
     "@zip.js/zip.js": "^2.7.29",
@@ -98,7 +98,7 @@
     "react-dom": "^18.1.0",
     "socksv5": "0.0.6",
     "ssim.js": "^3.5.0",
-    "typescript": "^5.3.2",
+    "typescript": "^5.5.3",
     "vite": "^5.0.13",
     "ws": "^8.17.1",
     "xml2js": "^0.5.0",

package.json

@@ -42,7 +42,6 @@ export function runDriver() {
   const isJavaScriptLanguageBinding = !process.env.PW_LANG_NAME || process.env.PW_LANG_NAME === 'javascript';
   const replacer = !isJavaScriptLanguageBinding && (String.prototype as any).toWellFormed ? (key: string, value: any): any => {
     if (typeof value === 'string')
-      // @ts-expect-error
       return value.toWellFormed();
     return value;
   } : undefined;

packages/playwright-core/src/cli/driver.ts

@@ -282,16 +282,16 @@ export async function convertInputFiles(files: string | FilePayload | string[] |
     if (!items.every(item => typeof item === 'string'))
       throw new Error('File paths cannot be mixed with buffers');
 
-    const [localPaths, localDirectory] = await resolvePathsAndDirectoryForInputFiles(items as string[]);
+    const [localPaths, localDirectory] = await resolvePathsAndDirectoryForInputFiles(items);
 
     if (context._connection.isRemote()) {
       const files = localDirectory ? (await fs.promises.readdir(localDirectory, { withFileTypes: true, recursive: true })).filter(f => f.isFile()).map(f => path.join(f.path, f.name)) : localPaths!;
       const { writableStreams, rootDir } = await context._wrapApiCall(async () => context._channel.createTempFiles({
-        rootDirName: localDirectory ? path.basename(localDirectory as string) : undefined,
+        rootDirName: localDirectory ? path.basename(localDirectory) : undefined,
         items: await Promise.all(files.map(async file => {
           const lastModifiedMs = (await fs.promises.stat(file)).mtimeMs;
           return {
-            name: localDirectory ? path.relative(localDirectory as string, file) : path.basename(file),
+            name: localDirectory ? path.relative(localDirectory, file) : path.basename(file),
             lastModifiedMs
           };
         })),

packages/playwright-core/src/client/elementHandle.ts

@@ -63,7 +63,7 @@ export class WKExecutionContext implements js.ExecutionContextDelegate {
   rawCallFunctionNoReply(func: Function, ...args: any[]) {
     this._session.send('Runtime.callFunctionOn', {
       functionDeclaration: func.toString(),
-      objectId: args.find(a => a instanceof js.JSHandle)!._objectId,
+      objectId: args.find(a => a instanceof js.JSHandle)!._objectId!,
       arguments: args.map(a => a instanceof js.JSHandle ? { objectId: a._objectId } : { value: a }),
       returnByValue: true,
       emulateUserGesture: true

packages/playwright-core/src/server/webkit/wkExecutionContext.ts

@@ -4815,9 +4815,9 @@ export type Fixtures<T extends KeyValue = {}, W extends KeyValue = {}, PT extend
 } & {
   [K in keyof PT]?: TestFixtureValue<PT[K], T & W & PT & PW> | [TestFixtureValue<PT[K], T & W & PT & PW>, { scope: 'test', timeout?: number | undefined, title?: string, box?: boolean }];
 } & {
-  [K in keyof W]?: [WorkerFixtureValue<W[K], W & PW>, { scope: 'worker', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
+  [K in Exclude<keyof W, keyof PW>]?: [WorkerFixtureValue<W[K], W & PW>, { scope: 'worker', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
 } & {
-  [K in keyof T]?: TestFixtureValue<T[K], T & W & PT & PW> | [TestFixtureValue<T[K], T & W & PT & PW>, { scope?: 'test', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
+  [K in Exclude<keyof T, keyof PT>]?: TestFixtureValue<T[K], T & W & PT & PW> | [TestFixtureValue<T[K], T & W & PT & PW>, { scope?: 'test', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
 };
 
 type BrowserName = 'chromium' | 'firefox' | 'webkit';

packages/playwright/types/test.d.ts

@@ -72,9 +72,9 @@ test('should check types of fixtures', async ({ runTSC }) => {
         baz: true,
       });
       const fail9 = test.extend<{ foo: string }>({
-        // @ts-expect-error
         foo: [ async ({}, use) => {
           await use('foo');
+          // @ts-expect-error
         }, { scope: 'test', auto: true } ],
       });
       const fail10 = test.extend<{}, {}>({

tests/playwright-test/types.spec.ts

@@ -144,9 +144,9 @@ export type Fixtures<T extends KeyValue = {}, W extends KeyValue = {}, PT extend
 } & {
   [K in keyof PT]?: TestFixtureValue<PT[K], T & W & PT & PW> | [TestFixtureValue<PT[K], T & W & PT & PW>, { scope: 'test', timeout?: number | undefined, title?: string, box?: boolean }];
 } & {
-  [K in keyof W]?: [WorkerFixtureValue<W[K], W & PW>, { scope: 'worker', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
+  [K in Exclude<keyof W, keyof PW>]?: [WorkerFixtureValue<W[K], W & PW>, { scope: 'worker', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
 } & {
-  [K in keyof T]?: TestFixtureValue<T[K], T & W & PT & PW> | [TestFixtureValue<T[K], T & W & PT & PW>, { scope?: 'test', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
+  [K in Exclude<keyof T, keyof PT>]?: TestFixtureValue<T[K], T & W & PT & PW> | [TestFixtureValue<T[K], T & W & PT & PW>, { scope?: 'test', auto?: boolean, option?: boolean, timeout?: number | undefined, title?: string, box?: boolean }];
 };
 
 type BrowserName = 'chromium' | 'firefox' | 'webkit';