@@ -782,31 +782,26 @@ async def test_wait_for_load_state_should_wait_for_load_state_of_new_page(
782782 assert await new_page .evaluate ("document.readyState" ) == "complete"
783783
784784
785- async def test_wait_for_load_state_should_resolve_after_popup_load (context , server ):
785+ async def test_wait_for_load_state_in_popup (context , server ):
786786 page = await context .new_page ()
787787 await page .goto (server .EMPTY_PAGE )
788- # Stall the 'load' by delaying css.
789788 css_requests = []
790- server .set_route ("/one-style.css" , lambda request : css_requests .append (request ))
789+
790+ def handle_request (request ):
791+ css_requests .append (request )
792+ request .write (b"body {}" )
793+ request .finish ()
794+
795+ server .set_route ("/one-style.css" , handle_request )
791796
792797 async with page .expect_popup () as popup_info :
793798 await page .evaluate (
794799 "url => window.popup = window.open(url)" , server .PREFIX + "/one-style.html"
795800 )
796- [popup , _ ] = await asyncio .gather (
797- popup_info .value ,
798- server .wait_for_request ("/one-style.css" ),
799- )
800801
801- resolved = []
802- load_state_task = asyncio .create_task (popup .wait_for_load_state ())
803- # Round trips!
804- for _ in range (5 ):
805- await page .evaluate ("window" )
806- assert not resolved
807- css_requests [0 ].finish ()
808- await load_state_task
809- assert popup .url == server .PREFIX + "/one-style.html"
802+ popup = await popup_info .value
803+ await popup .wait_for_load_state ()
804+ assert len (css_requests )
810805
811806
812807async def test_go_back_should_work (page , server ):
0 commit comments