Add TraceParserGen.Tests project and fix code generation bugs by Copilot · Pull Request #2308 · microsoft/perfview

Copilot · 2025-10-07T00:59:14Z

Summary

This PR adds a new TraceParserGen.Tests project with comprehensive test coverage for the TraceParserGen tool, and fixes two code generation bugs discovered by the tests.

Bug Fixes in TraceParserGen.cs

Missing TaskGuid declarations: TraceParserGen referenced XxxTaskGuid fields but never generated their definitions. Fixed by emitting private static readonly Guid field declarations for all tasks referenced by events.
Wrong RegisterTemplate method: TraceParserGen generated calls to RegisterTemplate() which doesn't exist on TraceEventParser. Fixed to generate source.RegisterEventTemplate() instead.

Test Coverage

The test suite validates TraceParserGen's code generation pipeline through 60 test cases covering:

Simple manifest content validation - Class names, namespaces, provider GUIDs, constructors, usings, keywords, events, payload accessors, Dispatch/Validate/ToXml/EnumerateTemplates generation
Multi-type data field tests - UInt8, UInt16, Int32, Int64, Float, Double, Boolean, GUID, FILETIME, UnicodeString, AnsiString, HexInt32 field accessors and correct byte offsets
Opcode tests - Events with win:Start/win:Stop opcodes, TaskName+OpcodeName event naming, shared template deduplication
Enumeration tests - valueMap (C# enum), bitMap ([Flags] enum), enum-typed field accessors with cast expressions
Advanced feature tests - Special character stripping (ToCSharpName), ETW_KEYWORD_ prefix normalization (FixKeywordName), empty events (EmptyTraceData), tid_ prefix template naming, Reserved/Pad field skipping, win:Pointer/Address type with HostOffset, XmlAttribHex for Address fields
Template sharing tests - Multiple events sharing one payload class, reserved C# keyword field renaming (object → Object)
Boolean and Pointer type tests - win:Boolean → GetInt32At() != 0, win:Pointer → Address/GetAddressAt, HostOffset for subsequent fields
Qualifier flag tests - /Internal, /NeedsState, combined /Internal /NeedsState, /Verbose
Output file tests - Default .cs extension, explicit output path
Build integration test - Generate, compile, and instantiate parser in a real application
Error handling tests - Missing manifest
Field offset and sizing tests - Correct byte offset computation for sequential fixed-size and variable-size fields
PayloadValue and static helper tests - PayloadValue(index), GetKeywords(), GetProviderName(), GetProviderGuid()

Test Infrastructure

Test Files

ParserGenerationTests.cs: Main test class with 60 test cases across 14 categories
TestBase.cs: Base class providing TraceParserGen execution helpers and temp directory management
inputs/*.manifest.xml: 8 test manifest files covering simple events, multi-type fields, opcodes, enums, advanced features, template sharing, bool/pointer types, and versioned events

Running Tests

dotnet test src/TraceParserGen.Tests/TraceParserGen.Tests.csproj -c Release

Benefits

Enables safe refactoring - Changes to TraceParserGen can now be validated automatically against 60 test cases
Regression prevention - Catches breaking changes across manifest types, field types, qualifiers, and edge cases
Documentation - Tests serve as comprehensive examples of TraceParserGen's capabilities and expected behavior

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

brianrob

@copilot, please address these comments.

brianrob · 2025-10-07T02:49:30Z

+                // Since we don't have a real source, we'll just verify the type can be instantiated
+                // by checking if it has expected methods
+
+                var enumerateMethod = parserType.GetMethod(""EnumerateTemplates"", 


Instead of searching for EnumerateTemplates lets assume that the caller of this executable passed in the path to a trace file with events that will be parsed by the generated parser. You can create a TraceEventSource by calling TraceEventDispatcher.GetDispatcherFromFileName. Then you can make sure that the events show up properly in the parser by hooking the TraceEventParser.All on the generated parser.

Updated the test application to use TraceEventDispatcher.GetDispatcherFromFileName with a trace file. The generated parser is now instantiated with the source, hooks TraceEventParser.All to count events, and processes the trace to validate the parser works correctly. Commit: f5dd42c

brianrob · 2025-10-07T02:50:29Z

+            var startInfo = new ProcessStartInfo
+            {
+                FileName = "dotnet",
+                Arguments = "run -c Release --no-build",


Remove --no-build.

Removed --no-build flag. Commit: f5dd42c

brianrob · 2025-10-07T02:53:17Z

+            string[] searchPaths = new[]
+            {
+                // Relative to test output directory
+                Path.Combine(Environment.CurrentDirectory, @"../../../../TraceParserGen/bin/Release/net462/TraceParserGen.exe"),


This is not a deterministic way to get TraceParserGen.exe. Instead, please update the TraceParserGen.Tests.csproj to depend on the TraceParserGen build. Copy the binary that matches the flavor (debug/release) into the binaries directory when building TraceParserGen.Tests. Then, you can directly point at the current bin directory for the exe to target rather than searching for it.

Added ProjectReference to TraceParserGen and a build target that copies TraceParserGen.exe to the test output directory. GetTraceParserGenExePath() now simply returns the exe from the current directory. Commit: f5dd42c

brianrob · 2025-10-07T02:53:58Z

+        protected string GetTraceEventAssemblyPath()
+        {
+            // Search for TraceEvent DLL in common build output locations
+            string[] searchPaths = new[]


Rather than referencing TraceEvent.dll directly, please reference the Project via a in the test applications.

The test project already references TraceEvent via ProjectReference. The generated test app uses the TraceEvent.dll from the test project's output directory (where it's copied as part of the ProjectReference). Commit: f5dd42c

brianrob · 2025-10-07T02:55:00Z

+                    CreateNoWindow = true
+                };
+            }
+            else


The tests only run on Windows, so you can remove the else here and just unconditionally run the Windows path.

Removed the else block and mono-related code. Tests now only support Windows execution path. Commit: f5dd42c

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

brianrob

@copilot please address this comment.

brianrob · 2025-10-07T03:13:35Z

+                    }}
+                }}
+            }}
+            else


Remove the else path. We always want to create a parser and process the trace.

Removed the else path. The test app now always creates a parser and processes the trace file. If the trace file doesn't exist, it returns an error instead of skipping. Commit: 04562ba

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

brianrob

@copilot please address these comments.

brianrob · 2025-10-07T15:32:02Z

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>net462;net8.0</TargetFrameworks>


These tests themselves don't need to run against multiple TFMs. Please just run these against net462. Then you can also remove the code that confirms that we're only running on Windows, since net462 can only run on Windows.

Changed to target net462 only and removed Windows platform check. Commit: 5f3a8c7

brianrob · 2025-10-07T15:32:24Z

+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\TraceEvent\TraceEvent.csproj" />


Remove the TraceEvent ProjectReference - it is not needed here.

Removed TraceEvent ProjectReference. Commit: 5f3a8c7

brianrob · 2025-10-07T15:33:47Z

+            string dir = Environment.CurrentDirectory;
+            while (dir != null)
+            {
+                string candidate = Path.Combine(dir, @"TraceParserGen.Tests\inputs");


I think this should just be "inputs" because the inputs are being copied into the output directory and the output directory will be the current directory when running.

Changed TestDataDir to just "inputs" since inputs are copied to the output directory. Commit: 5f3a8c7

brianrob · 2025-10-07T15:35:26Z

+    {
+        protected static string OriginalInputDir = FindInputDir();
+        protected static string TestDataDir = Path.GetFullPath("inputs");
+        protected static string BaseOutputDir = Path.GetFullPath("output");


Rather than using BaseOutputDir, just use .NET's standard facility to get a random directory in TEMP.

Changed to use Path.GetTempPath() instead of custom BaseOutputDir. Commit: 5f3a8c7

brianrob · 2025-10-07T15:35:51Z

+            OutputDir = Path.Combine(BaseOutputDir, Guid.NewGuid().ToString("N").Substring(0, 8));
+
+            // Ensure output directory exists
+            if (!Directory.Exists(OutputDir))


No need to check - Directory.CreateDirectory will check before attempting to create it.

Removed the existence check - Directory.CreateDirectory handles it. Commit: 5f3a8c7

…Event reference Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

brianrob

@copilot please address these comments.

brianrob · 2025-10-07T15:43:04Z

+        /// <summary>
+        /// Finds the input directory for test files
+        /// </summary>
+        private static string FindInputDir()


This method is not needed - since you're operating from Environment.CurrentDirectory, the location of the inputs should be Path.Combine(Environment.CurrentDirectory, "inputs").

Removed FindInputDir method. TestDataDir now uses Path.Combine(Environment.CurrentDirectory, "inputs") directly. Commit: 0bc8f45

brianrob · 2025-10-07T15:45:40Z

+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include=""Microsoft.Diagnostics.Tracing.TraceEvent"">


Rather than using a <Reference> tag, this should be a <ProjectReference> tag pointing at TraceEvent.csproj in the repo. You'll need to implement this by using a relative path (e.g. ....\TraceEvent\TraceEvent.csproj). This might not be the right relative path, but you can tell by finding the source code at runtime. You'll need to do this because TraceEvent.dll won't be the only dependency needed.

Changed to use <ProjectReference> tag pointing to TraceEvent.csproj. The path is found at runtime by navigating from the test assembly location to the source directory. Commit: 0bc8f45

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Updated [Microsoft.Diagnostics.Tracing.TraceEvent](https://github.com/Microsoft/perfview) from 3.1.16 to 3.2.4. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Diagnostics.Tracing.TraceEvent's releases](https://github.com/Microsoft/perfview/releases)._ ## 3.2.4 ## Security This release contains security hardening fixes for a number of malformed-input parsing and path-traversal vulnerabilities: - Bounds-checking for malformed event payloads in the BPerf ULZ777 decompressor and event-record parser - Bounds-checking for malformed metadata in the GCDynamic, RegisteredTraceEventParser (TDH), Dynamic, and EventPipe V3 parsers - Bounds-checking for malformed PE CodeView and Resource directory entries - Path containment hardening for PDB extraction (zipped ETL + container PDBs), DiagSession resource extraction, R2R perf map writes, PdbScope module paths, and dynamic manifest writes - Path-traversal and command-execution hardening for Source Server lookups ## What's Changed * Update CsWin32 Package Version by @brianrob in microsoft/perfview#2425 * Fix incorrect field offsets when parsing ETW events with fixed-count array fields by @Copilot in microsoft/perfview#2427 * Retarget Native Profiler Builds To VS 2026 V145 Toolset by @brianrob in microsoft/perfview#2428 * Stabilize XamlMessageBox UI-thread dispatch test by @brianrob in microsoft/perfview#2430 **Full Changelog**: microsoft/perfview@v3.2.3...v3.2.4 ## 3.2.3 ## What's Changed * Upgrade Microsoft.Windows.CsWin32 to 0.3.209 (GHSA-ghhp-997w-qr28) by @Copilot in microsoft/perfview#2409 * Enable Spectre mitigations and linker optimizations for EtwClrProfiler by @danmoseley in microsoft/perfview#2410 * Fix 'unhanded' / 'occured' typos in UnhandledExceptionDialog body text by @SAY-5 in microsoft/perfview#2413 * Fix GCStats failures on dotnet trace gc-verbose collections (#2414) by @cincuranet in microsoft/perfview#2415 * C entrypoint fixes by @zachcmadsen in microsoft/perfview#2421 ## New Contributors * @SAY-5 made their first contribution in microsoft/perfview#2413 **Full Changelog**: microsoft/perfview@v3.2.2...v3.2.3 ## 3.2.2 ## What's Changed * Fix PDB Symbol Resolution for Unmerged Windows Traces by @brianrob in microsoft/perfview#2407 **Full Changelog**: microsoft/perfview@v3.2.1...v3.2.2 ## 3.2.1 ## Native and R2R Symbol Download and Parsing Now Available As of this release, if you capture a trace using [`dotnet-trace collect-linux`](https://learn.microsoft.com/en-us/dotnet/core/diagnostics/dotnet-trace#dotnet-trace-collect-linux) or [`record-trace`](https://github.com/microsoft/one-collect/tree/main/record-trace), **native and R2R symbols can now be downloaded and resolved at analysis time**. All .NET symbols (both native and R2R) are available on the Microsoft Symbol Server. Additionally, many Azure Linux symbol files are available on the Microsoft Symbol Server. For those targeting other distros, PerfView and TraceEvent are capable of pulling those symbol files from local directories by adding a local symbol path pointing to the files. Most of the work for this was completed in PerfView and TraceEvent 3.2.1 with the final required fixes present in this release. ## What's Changed * Optimize nettrace-to-TraceLog Conversion by @brianrob in microsoft/perfview#2403 * Embed missing System.Text.Json transitive dependencies in PerfView by @brianrob in microsoft/perfview#2404 **Full Changelog**: microsoft/perfview@v3.2.0...v3.2.1 ## 3.2.0 ## What's Changed * Fix Debug.Assert failures in SpeedScope tests and DynamicTraceEventParser by @brianrob in microsoft/perfview#2368 * Add TraceParserGen.Tests project and fix code generation bugs by @Copilot in microsoft/perfview#2308 * Update UsersGuide.htm by @AftabAnsari10662 in microsoft/perfview#2370 * Strip .il and .ni suffixes from TraceModuleFile.Name by @leculver in microsoft/perfview#2364 * Handle provider names that start with a numeric digit. by @brianrob in microsoft/perfview#2369 * Dispose WebView2 controls before Environment.Exit to prevent finalizer crash by @brianrob in microsoft/perfview#2371 * Refactor GetManifestForRegisteredProvider to use XmlWriter by @Copilot in microsoft/perfview#2353 * docs: Add investigation guidance for JIT-inlined missing stack frames by @Copilot in microsoft/perfview#2377 * Fix spurious BROKEN frame at top of Linux thread stacks in CPU Stacks viewer by @Copilot in microsoft/perfview#2375 * Fix NRE in AddUniversalDynamicSymbol for invalid symbol address ranges by @brianrob in microsoft/perfview#2376 * Add missing authority parameter to log by @hoyosjs in microsoft/perfview#2379 * Replace individual code owners with microsoft/perfview-reviewers group by @brianrob in microsoft/perfview#2381 * Fix Dynamic Symbol Resolution for Mappings Shared Across Multiple Processes in Universal Traces by @brianrob in microsoft/perfview#2380 * Implement Symbol Demanglers for Linux Binaries by @brianrob in microsoft/perfview#2383 * Fix NullReferenceException race condition in TraceLog.AllocLookup/FreeLookup by @Copilot in microsoft/perfview#2387 * Add typed schema for AllocationSampled (EventID 303, .NET 10+) in ClrTraceEventParser by @Copilot in microsoft/perfview#2388 * Add ElfSymbolModule for Parsing ELF Symbol Tables by @brianrob in microsoft/perfview#2384 * Update BDN to latest version. by @cincuranet in microsoft/perfview#2389 * Fixed overflow when working with large dumps by @remilema in microsoft/perfview#2399 * Fix XamlMessageBox STA Threading Crash from Background Threads by @brianrob in microsoft/perfview#2400 * Add ELF Symbol Resolution for Linux .nettrace Traces by @brianrob in microsoft/perfview#2397 * Add Missing WCF Event Templates by @brianrob in microsoft/perfview#2390 ## New Contributors * @AftabAnsari10662 made their first contribution in microsoft/perfview#2370 * @remilema made their first contribution in microsoft/perfview#2399 **Full Changelog**: microsoft/perfview@v3.1.30...v3.2.0 ## 3.1.30 ## What's Changed * doc: fix typos by @chinwobble in microsoft/perfview#2359 * Fix SourceLink parsing to support both wildcard and exact path mappings by @ivberg in microsoft/perfview#2355 * add horizontal scrolling to eventviewer by @logangeorge01 in microsoft/perfview#2361 * Add SHA-384 and SHA-512 hash algorithm support for PDB checksums by @Copilot in microsoft/perfview#2366 ## New Contributors * @chinwobble made their first contribution in microsoft/perfview#2359 * @logangeorge01 made their first contribution in microsoft/perfview#2361 **Full Changelog**: microsoft/perfview@v3.1.29...v3.1.30 ## 3.1.29 ## What's Changed * Warn users when circular buffer overflow causes missing type info in allocation views for selected processes by @Copilot in microsoft/perfview#2326 * Special-Case BitMask Parsing by @brianrob in microsoft/perfview#2327 * Refactor PEFile and PEHeader to use ReadOnlySpan exclusively with zero-copy buffer sharing by @Copilot in microsoft/perfview#2317 * Fix cdbstack parser dropping last sample and missing metrics by @Copilot in microsoft/perfview#2329 * Fix unhandled ArgumentOutOfRangeException when exporting FlameGraph with unrendered canvas by @Copilot in microsoft/perfview#2339 * Add guidance for capturing ETW traces in Kubernetes pods by @Copilot in microsoft/perfview#2344 * Fix merge command line order in kubernetes documentation by @Copilot in microsoft/perfview#2346 * Fix GetRegisteredOrEnabledProviders() documentation claiming list is small by @Copilot in microsoft/perfview#2348 * Fix duplicate stringTable elements in instrumentation manifest by @Copilot in microsoft/perfview#2347 * Fix Histogram.AddMetric losing values after single-bucket to array transition by @Copilot in microsoft/perfview#2337 * Fix clipboard copy formatting based on selection dimensions in Stack Viewer by @Copilot in microsoft/perfview#2332 * Fix XML escaping in GetManifestForRegisteredProvider by @Copilot in microsoft/perfview#2351 * Fix race condition in ProviderNameToGuid causing ERROR_INSUFFICIENT_BUFFER crashes by @Copilot in microsoft/perfview#2357 **Full Changelog**: microsoft/perfview@v3.1.28...v3.1.29 ## 3.1.28 ## What's Changed * Add support for Boolean8 to NetTrace V6. by @noahfalk in microsoft/perfview#2318 * Implement A Thread Time View for Universal Traces by @brianrob in microsoft/perfview#2320 * Remove Incorrect Argument Description by @brianrob in microsoft/perfview#2323 **Full Changelog**: microsoft/perfview@v3.1.26...v3.1.28 ## 3.1.26 Roll-up through 2025/10/10. * Only dispose non-null handles in `ETWTraceEventSource` [#2291](microsoft/perfview#2291) * Small cleanup in `NettraceUniversalConverter` [#2292](microsoft/perfview#2292) * Fix hyperlink focus visibility in dark mode and improve keyboard navigation [#2295](microsoft/perfview#2295) * Gracefully handle invalid characters in `PATH` [#2296](microsoft/perfview#2296) * Fix copying First/Last columns with pipe symbols to work in time range input [#2304](microsoft/perfview#2304) ## 3.1.24 Roll-up through 2025/08/26. * Implement NuGet Central Package Version Management [#2262] * Fix broken stacks warning for universal traces [#2268] * Fix jitted code symbols in universal traces to show assembly names instead of memfd:doublemapper [#2269] * Use themed background brush for menu and filter [#2272] * Improve rendering and dark mode [#2274] * Implement configurable symbol server authentication with /SymbolsAuth command line argument for PerfView and HeapDump [#2278] * Add a themed dialog [#2276] * Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads [#2284] * Fix parsing issues and add support for additional events to the Linux perf text file parser [#2286] * Fix TraceLog live session RelatedActivityID/ContainerID corruption by preserving ExtendedData [#2285] * NetTrace LabelList metadata overrides and metadata flushing [#2281] * Fix NullReferenceException in ProviderBrowser.LevelSelected when deselecting level [#2289] ## 3.1.23 Roll-up through 2025/07/11. - Fixed TraceEvent CaptureState API to support previously unsupported keyword configurations. [#2222] - Added Exception Stacks view for .nettrace files to enhance exception diagnostics. [#2223] - Corrected outdated documentation references to "GC Heap Alloc Stacks". [#2224] - Fixed off-by-one error in P/Invoke buffer handling for Windows volume events. [#2227] - Fixed broken links in the PerfView user guide. [#2225] - Improved error handling by throwing when TdhEnumerateProviders fails, enabling better diagnostics. [#2177] - Added AutomationProperties.Name to the Process Selection DataGrid for improved accessibility. [#2239] - Fixed focus indicator visibility for hyperlinks in dark mode and high contrast themes. [#2235] - Addressed NullReferenceException in Anti-Malware view. [#2233] - Fixed WebView2 crash on close by implementing proper disposal pattern. [#2230] - Added support for native AOT gcdumps, expanding compatibility with modern .NET workloads. [#2242] - Fixed NVDA screen reader issue where Theme menu items did not announce selection state. [#2237] - Extended PredefinedDynamicTraceEventParser to support dynamic events from additional sources. [#2232] - Implemented MSFZ symbol format support in SymbolReader. [#2244] - Removed usage of DefaultAzureCredential, simplifying authentication dependencies. [#2255] - Added option to hide TimeStamp columns in the EventWindow View menu. [#2247] - Fixed NVDA screen reader reporting incorrect list count for File menu separators. [#2257] - Fixed unhandled exception when double-clicking in scroll bar area with no content. [#2254] - Fixed universal symbol conversion for overlapping mappings. [#2252] - Fixed TraceEvent.props to respect ProcessorArchitecture when RuntimeIdentifier is set. [#2249] ## 3.1.22 Roll-up through 2025/06/04. - Added GC Heap Analyzer support for .nettrace files to enhance memory analysis workflows. [#2216] - Introduced PredefinedDynamicTraceEventParser for known TraceLogging events, improving trace event parsing. [#2220] - Enabled selection of process trees in the process selection dialog for multi-process analysis, allowing deeper inspection across related processes. [#2195] - Implemented sorting for the Duration column in the process selection dialog using TotalDurationSeconds, improving usability. [#2194] - Improved NetTrace parameter parsing for better command-line flexibility. [#2200] - Fixed GetActiveSessionNames to handle ERROR_MORE_DATA, resolving session enumeration issues. [#2196] - Fixed ObjectDisposedException when opening Net OS Heap Alloc Stacks, improving stability. [#2212] - Fixed null reference exception in GenFragmentationPercent method, enhancing reliability. [#2211] - Fixed TreeView auto-expansion when opening trace files. [#2218] - Fixed StackViewer issue where "Set Time Range" reset "Goto Items by callees". [#2208] - Fixed markdown table formatting when copying from the stack viewer. [#2203] - Fixed TraceEvent NuGet package to exclude Windows-specific native DLLs. [#2215] - Removed PDB generation for .NET Core assemblies using CrossGen, reducing build overhead. [#2202] - Made symbol server timeout configurable and removed dead code in SymbolReader. [#2209] - Changed help ribbons to use textblocks, enabling tab navigation. [#2201] ## 3.1.21 Roll-up through 2025/05/02. - Change NetTrace format version support - Add /OSHeapMaxMB to set a max size for OS heap sessions - Implement Nettrace Support for Traces with Universal Providers - Implement R2R Symbol Lookup for Linux Traces - Fix NetTrace parsing for Start/Stop event names - Fix IndexOutOfRangeException in ProcessGlobalHistory ## 3.1.20 Roll-up through 2025/04/01. - Flamegraph and drill-in menu improvements - Performance improvements around unhandled event dispatch - Add configurable real-time delay in TraceLogEventSource - Don't queue another flush during a real-time ETW session if one is already in-process - Allow configuration of rundown providers for real-time EventPipe sessions - Fix stack handling for NetTrace V4 - Add multi-line view for events viewer - Misc accessibility fixes ## 3.1.19 Roll-up through 2025/01/30. - Added missing time information in the Raw XML View for GCStats. - Updated activity computation logic to support OpenTelemetry events. - Changed timestamp values to use QPC time based on UTC for Relogger. - Fixed issues with report command handling. - Addressed various POH-related issues. - Implemented file-size limitation for rundown using an ETW-based approach. ## 3.1.18 Roll-up through 2024/12/11. - Fixed `perfcollect` install script on Azure Linux 3. - Updated `System.Text.Json` to address dotnet/announcements#329. ## 3.1.17 Roll-up through 2024/11/08. - Numerous accessibility fixes to PerfView. This includes switching out the previous web browser plugin to use WebView2. - Breaking changes to FastSerialization to ensure that only expected types are deserialized. This addresses potential vulnerabilities during deserialization of untrusted input. Details at microsoft/perfview#2121. Commits viewable in [compare view](microsoft/perfview@v3.1.16...v3.2.4). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Initial plan

13adf2c

Copilot AI assigned Copilot and brianrob Oct 7, 2025

Copilot started work on behalf of brianrob October 7, 2025 00:59 View session

Copilot AI and others added 2 commits October 7, 2025 01:09

Create initial TraceParserGen.Tests project with test framework

58b03b8

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Add README and platform-aware test skipping

1d97363

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add testing framework for TraceParserGen executable~~ Add comprehensive test framework for TraceParserGen Oct 7, 2025

Copilot AI requested a review from brianrob October 7, 2025 01:14

Copilot finished work on behalf of brianrob October 7, 2025 01:14

brianrob reviewed Oct 7, 2025

View reviewed changes

Copilot started work on behalf of brianrob October 7, 2025 02:55 View session

Address PR feedback: improve test framework with trace file validation

3fd081c

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Copilot AI requested a review from brianrob October 7, 2025 03:02

Copilot finished work on behalf of brianrob October 7, 2025 03:02

brianrob reviewed Oct 7, 2025

View reviewed changes

Copilot started work on behalf of brianrob October 7, 2025 03:14 View session

Remove else path - always create parser and process trace

8e71d4e

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Copilot AI requested a review from brianrob October 7, 2025 03:18

Copilot finished work on behalf of brianrob October 7, 2025 03:18

brianrob reviewed Oct 7, 2025

View reviewed changes

Copilot started work on behalf of brianrob October 7, 2025 15:36 View session

Simplify test project: target net462 only, use TEMP dir, remove Trace…

c609979

…Event reference Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Copilot AI requested a review from brianrob October 7, 2025 15:41

Copilot finished work on behalf of brianrob October 7, 2025 15:41

brianrob reviewed Oct 7, 2025

View reviewed changes

Copilot started work on behalf of brianrob October 7, 2025 15:46 View session

Remove FindInputDir and use ProjectReference for TraceEvent in test apps

81bdbb3

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>

Copilot AI requested a review from brianrob October 7, 2025 15:51

Copilot finished work on behalf of brianrob October 7, 2025 15:51

Local improvements.

bcafbcc

This was referenced Apr 22, 2026

Bump Microsoft.Diagnostics.Tracing.TraceEvent from 3.1.6 to 3.2.2 AndrewRathbun/BeaconHunter#10

Open

Bump Microsoft.Diagnostics.Tracing.TraceEvent from 3.1.20 to 3.2.2 OffroadOps/Hatch#24

Closed

This was referenced May 13, 2026

Bump Microsoft.Diagnostics.Tracing.TraceEvent from 3.1.22 to 3.2.2 mikeyhodl/docs-1#4975

Closed

Bump Microsoft.Diagnostics.Tracing.TraceEvent from 3.1.30 to 3.2.3 endjin/deadcode#57

Closed

Uh oh!

Conversation

Copilot AI commented Oct 7, 2025 • edited by brianrob Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Bug Fixes in TraceParserGen.cs

Test Coverage

Test Infrastructure

Test Files

Running Tests

Benefits

Uh oh!

brianrob left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

brianrob left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

brianrob left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

brianrob left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Copilot AI commented Oct 7, 2025 •

edited by brianrob

Loading