Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/onnxscript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.7
Choose a base ref
...
head repository: microsoft/onnxscript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 8 commits
  • 88 files changed
  • 2 contributors

Commits on May 27, 2025

  1. Update publish pipelines to use 1ES templates (#2349)

    Update the workflow using 1ESPipelineTemplates
    justinchuby authored May 27, 2025
    Configuration menu
    Copy the full SHA
    b5b51c0 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2025

  1. [pass] Update LiftSubgraphInitializersToMainGraphPass to disallow var…

    …iable shadowing (#2348)
    
    Variable shadowing (reusing value names) is disallowed in ONNX across
    the main graph and subgraphs according to the spec
    (https://github.com/onnx/onnx/pull/6955/files). This change updates to
    the logic to check and raise on such cases. A subsequent PR will
    implement #1432 to allow users to fix names explicitly.
    justinchuby authored May 28, 2025
    Configuration menu
    Copy the full SHA
    77fba51 View commit details
    Browse the repository at this point in the history
  2. Fix cross attention in MHA (#2337)

    Fix a seeming bug in handling of cross-attention in MHA (to be
    verified): In MHA fusion, we start with an input graph where attention
    is applied to 4D query/key/value, and it is transformed into a MHA op on
    3D query/key/value.
    
    In the case of cross-attention (with no rotary-embedding): the fusion
    seems to convert just query to 3D, and seems to leave key and value as
    4D, which seems wrong.
    
    This PR adds the necessary 4D=>3D conversion for key/value before MHA.
    
    Note: This is a quick fix for the relevant case (that shows up). Other
    combinations may be worth checking out separately.
    
    ---------
    
    Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
    Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
    gramalingam and justinchuby authored May 28, 2025
    Configuration menu
    Copy the full SHA
    5a8b9e6 View commit details
    Browse the repository at this point in the history
  3. [torchlib] Set allowzero=True on Reshape where appropriate (#2346)

    When we reshape from a dynamic shape, the shape can contain zeros. This
    change accounts for those cases.
    justinchuby authored May 28, 2025
    Configuration menu
    Copy the full SHA
    8c0046f View commit details
    Browse the repository at this point in the history
  4. [torchlib] Fix pow.Tensor_Scalar type promotion (#2335)

    Fix pow.Tensor_Scalar type promotion by accounting different combination
    of input dtypes. This change ensures the inputs to Pow is always the
    same type for compatibility with downstream tools.
    
    Also
    - Added is_floating_point for dtype for convienience. The method naming
    follows
    https://docs.pytorch.org/docs/stable/generated/torch.is_floating_point.html
    - Simplify value str when it is constant.
    
    Fix #2213
    justinchuby authored May 28, 2025
    Configuration menu
    Copy the full SHA
    61d4ab5 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2025

  1. Formally drop python 3.8 support (#2354)

    Python 3.8 has reached EOL.
    
    Fix #2233
    justinchuby authored May 29, 2025
    Configuration menu
    Copy the full SHA
    881369f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2025

  1. Implement __repr__ for MatchResult (#2353)

    This pull request adds a `__repr__` method to the `MatchResult` class in
    `onnxscript/rewriter/_basics.py`. The new method provides a string
    representation of the match result, improving debugging and readability.
    justinchuby authored May 30, 2025
    Configuration menu
    Copy the full SHA
    1620320 View commit details
    Browse the repository at this point in the history
  2. Use onnx_ir as a dependency (#2324)

    Take `onnx_ir` as a dependency and expose onnxscript.ir as an alias of
    `onnx_ir`.
    justinchuby authored May 30, 2025
    Configuration menu
    Copy the full SHA
    143c531 View commit details
    Browse the repository at this point in the history
Loading