Add OpenVINO EP shared lib to Py Wheel #5920

smkarlap · 2020-11-24T23:34:20Z

Description: Include the libonnxruntime_providers_openvino.so/.dll to the whl package.

Motivation and Context

OpenVINO EP is now built as a separate shared library, and needs to be explicitly included in the .whl package for python builds

Include the libonnxruntime_providers_openvino.so/.dll to the wheel

jywu-msft · 2020-11-24T23:38:23Z

@RyanUnderhill

setup.py

jywu-msft · 2020-11-24T23:41:10Z

setup.py

  # DirectML Libs
  libs.extend(['directml.dll'])
+  # OpenVINO Libs
+  libs.extend(['onnxruntime_providers_openvino.dll'])


same comment as above. and should we add for Mac OSX?

We don't support Mac OSX yet. So not adding one for now.

ok. but openvino does support mac osx. we can add an item to backlog.

yes, we will.

jywu-msft · 2020-11-25T01:04:36Z

/azp run Windows GPU TensorRT CI Pipeline

azure-pipelines · 2020-11-25T01:04:45Z

Azure Pipelines successfully started running 1 pipeline(s).

snnn · 2020-11-25T02:43:10Z

/azp run orttraining-linux-ci-pipeline
/azp run centos7_cpu

azure-pipelines · 2020-11-25T02:43:15Z

No pipelines are associated with this pull request.

snnn · 2020-11-25T02:43:26Z

/azp run orttraining-linux-ci-pipeline

azure-pipelines · 2020-11-25T02:43:35Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-11-25T04:01:02Z

/azp run Linux CPU CI Pipeline

jywu-msft · 2020-11-25T04:01:25Z

/azp run Linux CPU Minimal Build E2E CI Pipeline

azure-pipelines · 2020-11-25T04:01:35Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-11-25T04:01:40Z

/azp run Linux CPU x64 NoContribops CI Pipeline

jywu-msft · 2020-11-25T04:01:51Z

/azp run Linux OpenVINO CI Pipeline

azure-pipelines · 2020-11-25T04:02:01Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-11-25T04:02:23Z

/azp run Linux GPU CI Pipeline

jywu-msft · 2020-11-25T04:02:35Z

/azp run Linux GPU TensorRT CI Pipeline

jywu-msft · 2020-11-25T04:02:51Z

/azp run MacOS CI Pipeline

azure-pipelines · 2020-11-25T04:03:00Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-11-25T04:03:15Z

/azp run centos7_cpu

azure-pipelines · 2020-11-25T04:03:23Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-11-25T04:03:29Z

/azp run Windows CPU CI Pipeline

jywu-msft · 2020-11-25T04:03:42Z

/azp run Windows GPU CI Pipeline

azure-pipelines · 2020-11-25T04:03:50Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-11-25T04:03:54Z

/azp run MacOS NoContribops CI Pipeline

* Add OpenVINO EP shared lib to Py Wheel Include the libonnxruntime_providers_openvino.so/.dll to the wheel * Follow libs.extend pattern as other EPs (cherry picked from commit 4092686)

@tracysh

* Update onnx (#5720) * update onnx * update docker image for testing (cherry picked from commit 705d093) * cherry pick PR 5720 * C#: Add CreateFromMemory to FixedBufferOnnxValue to allow bind user buffers and pass custom binary compatible types (#5886) Add CreateFromMemory to FixedBufferOnnxValue so users can bind their own custom binary compatible buffers to feed/fetch data. (cherry picked from commit c2d6100) * [Java] Initial Apple Silicon support (#5891) * Rearranging checks in onnxruntime_mlas.cmake to pickup Apple Silicon. On an M1 Macbook Pro clang reports: $ clang -dumpmachine arm64-apple-darwin20.1.0 So the regex check needs to look for "arm64" first, as otherwise it matches 32-bit ARM and you get NEON compilation failures. * Adding Java side library loading support for Apple Silicon (and other aarch64 architectures). * Adding Qgemm fix from @tracysh * Fixes the java packaging on Windows. * Missed a check in the java platform detector. (cherry picked from commit 8b83c51) * Add OpenVINO EP shared lib to Py Wheel (#5920) * Add OpenVINO EP shared lib to Py Wheel Include the libonnxruntime_providers_openvino.so/.dll to the wheel * Follow libs.extend pattern as other EPs (cherry picked from commit 4092686) * Make NNAPI EP reject nodes with no-shape inputs (#5927) (cherry picked from commit 8736865) * Sahar/fix documentation shared lib (#5926) * Update OpenVINO-ExecutionProvider.Md update openvino-executionprovider.md for shared library * Update Build.md updated --build_shared_lib flag for building openvino shared provider lib * Update Dockerfile.openvino building for shared library with the new changes for openvino shared lib * Revert "Update Build.md" This reverts commit c9cf5fe. * Revert "Update Dockerfile.openvino " This reverts commit e1624e4. * Update OpenVINO-ExecutionProvider.md fix documentation to the shared library Co-authored-by: sfatimar <sahar.fatima@intel/com> (cherry picked from commit 8168c91) * Update dockerfiles (#5929) 1. Remove conda from the images. Because conda contains a file named /opt/miniconda/lib/libcrypto.so.1.0.0 which can't pass our security scan. Also, it will be easier for us to manage the third party usage registrations. 2. Remove openssh from the images. Because the official openssh package provided by Ubuntu can't pass our security scan. 3. Reduce the image size to 1/3 by using stages. Also, because it contains less packages, it will be less often needed to update. 4. Put the LICENSE-IMAGE.txt file in right place. It is missed in current images. You can see it was added to a temp folder "/code" but it got deleted afterwards. 5. Update the CPU docker image's base image to Ubuntu 18.04. The GPU one is already 18.04. It's better to keep them the same. 6. Remove the build arg ONNXRUNTIME_REPO/ONNXRUNTIME_BRANCH. Instead, the new one always uses the local source. I feel it can reduce confusion. (cherry picked from commit 1dbabb2) * Add Longformer Attention Cuda Op(#5932) Limitation: Global tokens must be at the beginning of sequence. (cherry picked from commit 31a6be3) * Bug fix for MaskRCNN and FasterRCNN (#5935) Signed-off-by: MaajidKhan <n.maajidkhan@gmail.com> (cherry picked from commit e39e82b) * Fix publishing pipelines. (#5942) Fix publishing pipelines. (cherry picked from commit c4b55d2) * Fix Python Linux GPU package name (#5943) Fix Python Linux GPU package name. I accidentally added "noopenmp" to it. (cherry picked from commit 5fdd9f0) * Update BUILD.md with shared provider information (#5944) * Update build instructions to include information about shared providers (cherry picked from commit 27513d1) * [OpenVINO]Fix memory leak in `IsDebugEnabled()` under Windows (#5948) * w * w Co-authored-by: modav <modav@microsoft.com> (cherry picked from commit e207589) * Add support for Python 3.8+ on Windows when CUDA is enabled (#5956) (cherry picked from commit 015fbb3) * Support the cross compiling for Apple Silicon (#5974) * support macos_arm64 cross compiling * update the build docs * update as commented. * Update BUILD.md (cherry picked from commit 2ec211e) * Update docker files to put 'unattended-upgrades' in a right place(#5983) (cherry picked from commit 3323fb6) * Enable the xcode build for Apple Silicon (arm64 MacOS) (#5924) * fix the build script for macos/xcode * add the version check * correct the osx-arch configuration * typo (cherry picked from commit 1852ade) * Add python 3.9 support (#5874) 1. Add python 3.9 support(except Linux ARM) 2. Add Windows GPU python 3.8 to our packaging pipeline. * Revert some pipeline changes in #5874 Co-authored-by: Ashwini Khade <askhade@microsoft.com> Co-authored-by: Du Li <duli@OrtTrainingDev0.af05slrtruoetgaxwwjv5nsq5e.px.internal.cloudapp.net> Co-authored-by: Dmitri Smirnov <yuslepukhin@users.noreply.github.com> Co-authored-by: Adam Pocock <craigacp@gmail.com> Co-authored-by: S. Manohar Karlapalem <manohar.karlapalem@intel.com> Co-authored-by: Guoyu Wang <62914304+gwang-msft@users.noreply.github.com> Co-authored-by: sfatimar <64512376+sfatimar@users.noreply.github.com> Co-authored-by: Changming Sun <chasun@microsoft.com> Co-authored-by: Tianlei Wu <tlwu@microsoft.com> Co-authored-by: Maajid khan <n.maajidkhan@gmail.com> Co-authored-by: Ryan Hill <38674843+RyanUnderhill@users.noreply.github.com> Co-authored-by: Moshe David <mosdav165@gmail.com> Co-authored-by: Ivan Stojiljkovic <17503404+ivanst0@users.noreply.github.com> Co-authored-by: Wenbing Li <10278425+wenbingl@users.noreply.github.com>

Add OpenVINO EP shared lib to Py Wheel

447023b

Include the libonnxruntime_providers_openvino.so/.dll to the wheel

smkarlap requested a review from a team as a code owner November 24, 2020 23:34

jywu-msft reviewed Nov 24, 2020

View reviewed changes

setup.py Outdated Show resolved Hide resolved

pranavsharma added the release:1.6 label Nov 24, 2020

jywu-msft reviewed Nov 24, 2020

View reviewed changes

Follow libs.extend pattern as other EPs

ad9552e

snnn approved these changes Nov 25, 2020

View reviewed changes

jywu-msft approved these changes Nov 25, 2020

View reviewed changes

jywu-msft merged commit 4092686 into microsoft:master Nov 25, 2020

faxu added the triage:approved label Dec 1, 2020

smkarlap deleted the manohar/python-shared-lib branch December 2, 2020 04:11

duli2012 mentioned this pull request Dec 2, 2020

Cherry picking for Rel-1.6 #6006

Merged

faxu removed the release:1.6 label Dec 4, 2020

Add OpenVINO EP shared lib to Py Wheel #5920

Add OpenVINO EP shared lib to Py Wheel #5920

Uh oh!

Conversation

smkarlap commented Nov 24, 2020

Uh oh!

jywu-msft commented Nov 24, 2020

Uh oh!

Uh oh!

jywu-msft Nov 24, 2020

Choose a reason for hiding this comment

Uh oh!

smkarlap Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

jywu-msft Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

smkarlap Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

snnn commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

snnn commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

azure-pipelines bot commented Nov 25, 2020

Uh oh!

jywu-msft commented Nov 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants