Skip to content

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Nov 21, 2020

Description:

It got removed in #5778. But the Android pipeline needs it.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from a team as a code owner November 21, 2020 02:15
@guoyu-wang
Copy link
Contributor

guoyu-wang commented Nov 21, 2020

Do you think it's better we add 'python3' in front of the current CI definition? So this won't get affected by this kind of accidental change?

  • script: python3 tools/ci_build/build.py --android --build_dir build --android_sdk ...

@snnn
Copy link
Contributor Author

snnn commented Nov 21, 2020

Do you think it's better we add 'python3' in front of the current CI definition? So this won't get affected by this kind of accidental change?

I feel either is fine. You can decide it.

@skottmckay
Copy link
Contributor

Do you think it's better we add 'python3' in front of the current CI definition? So this won't get affected by this kind of accidental change?

I feel either is fine. You can decide it.

Given this has happened twice recently, adding python3 is probably better long term.

It happened to me on Windows and I didn't make any direct or intentional changes to the permissions for build.py (and given it was Windows it wasn't even obvious it had changed).

@guoyu-wang
Copy link
Contributor

guoyu-wang commented Nov 21, 2020

Do you think it's better we add 'python3' in front of the current CI definition? So this won't get affected by this kind of accidental change?

I feel either is fine. You can decide it.

Given this has happened twice recently, adding python3 is probably better long term.

It happened to me on Windows and I didn't make any direct or intentional changes to the permissions for build.py (and given it was Windows it wasn't even obvious it had changed).

This #5889 has the change to add python3 to CI command, it was trying to fix another unrelated Android CI failure

@snnn snnn closed this Nov 23, 2020
@snnn snnn deleted the snnn/p103 branch November 23, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants