Repository navigation
INT3 QMoE review fixes and per-block padding experiment - #33530
Draft
David Fan (jiafatom) wants to merge 1 commit into
Draft
David Fan (jiafatom) wants to merge 1 commit into
David Fan (jiafatom) wants to merge 1 commit into
Conversation
Signed-off-by: David Fan <jiafa@microsoft.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolated follow-up to #33394, intentionally on a separate branch without modifying its head.
Experiment
A100-SXM4-80GB, CUDA13, actual Qwen FC1/FC2 dimensions, block32/64/128, compact versus 16/32-byte-aligned blocks, fixed8 and rotating128 experts, dequantization and one/32-token projections. Two runs of 108 cases each; seven trials per case; prefill16calls covers all128experts. Layout outputs match and independent scalar samples pass.
Block64 padding24->32bytes increases weight payload33.33%; rotating128expert decode is about11% slower and32token projection about10% slower in this scalar-load implementation. Byte-only padding adds nothing for these block sizes. This does not rule out future vectorized private layouts and is not a whole-model benchmark or pure bandwidth attribution.
Validation
Normal current-source schema/format tests17/17 passed. Format translation unit and real helper.cc compiled with ORT_NO_EXCEPTIONS:6/6 passed. Uses cached dependencies/isolated objects, not a clean full or globally exception-disabled build. After formatting, rebuilt benchmark quick108checks pass. Both full JSON protocols and report table verified.
Original #33394 code threads remain open until these changes enter its branch; this follow-up does not imply PR2-PR4 completion.