CoreML: Disable 1D ML Program matmul due to bug in coreml #21186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CoreML ML Program implementation does not appear to handle it correctly. Manually checked that the ONNX input/output shapes were all correct and as required by the CoreML spec, so appear to be creating the ML Program model correctly.
edgchen1
reviewed
Jun 27, 2024
onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc
Outdated
Show resolved
Hide resolved
|
could you also try enabling the CoreML EP in the MacOS 14 CI build? onnxruntime/.github/workflows/mac.yml Lines 50 to 60 in 8f738d8 |
snnn
previously approved these changes
Jun 27, 2024
edgchen1
approved these changes
Jun 28, 2024
snnn
approved these changes
Jun 28, 2024
|
/azp run Big Models , orttraining-ortmodule-distributed |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run Big Models |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable using CoreML ML Program for a matmul where one of the inputs is 1D as the CoreML implementation appears to be broken. See apple/coremltools#2263
Add some debugging notes.
Motivation and Context
Fix failing test on macos-14.