Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@kananb
Copy link
Contributor

@kananb kananb commented Oct 17, 2023

Summary of the Pull Request

Makes min_available_memory_mb configurable per task from the CLI and service.

PR Checklist

  • Applies to work item: Allow the min_available_memory_mb to be configurable per task #3518
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@kananb kananb requested a review from chkeita October 17, 2023 21:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #3577 (ea6217b) into main (679309a) will increase coverage by 0.00%.
The diff coverage is 12.50%.

@@           Coverage Diff           @@
##             main    #3577   +/-   ##
=======================================
  Coverage   39.00%   39.00%           
=======================================
  Files         302      302           
  Lines       36958    36963    +5     
=======================================
+ Hits        14414    14419    +5     
  Misses      22544    22544           
Files Coverage Δ
...e/onefuzzlib/notifications/JinjaTemplateAdapter.cs 90.88% <100.00%> (+0.02%) ⬆️
src/ApiService/ApiService/OneFuzzTypes/Model.cs 70.51% <50.00%> (-0.05%) ⬇️
src/ApiService/ApiService/onefuzzlib/Config.cs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/managed/cmd.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@kananb kananb changed the title Kanan/task memory Make min_available_memory_mb configurable Oct 17, 2023
@kananb kananb force-pushed the kanan/task-memory branch from 23168c4 to 1468d3b Compare October 17, 2023 22:04
@kananb kananb marked this pull request as ready for review October 18, 2023 20:54
@kananb kananb merged commit d9ac2a7 into main Oct 18, 2023
@kananb kananb deleted the kanan/task-memory branch October 18, 2023 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants