Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@kananb
Copy link
Contributor

@kananb kananb commented Aug 3, 2023

Summary of the Pull Request

Adds validation for Iteration/AreaPath when a job is submitted with a notification config and for onefuzz debug notification test_template.

PR Checklist

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #3386 (229f88f) into main (c49442f) will decrease coverage by 0.05%.
The diff coverage is 2.17%.

@@            Coverage Diff             @@
##             main    #3386      +/-   ##
==========================================
- Coverage   34.46%   34.42%   -0.05%     
==========================================
  Files         299      299              
  Lines       36201    36245      +44     
==========================================
  Hits        12478    12478              
- Misses      23723    23767      +44     
Files Changed Coverage Δ
...iService/ApiService/Functions/NotificationsTest.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
...ce/ApiService/onefuzzlib/NotificationOperations.cs 23.07% <0.00%> (-0.18%) ⬇️
...Service/ApiService/onefuzzlib/notifications/Ado.cs 24.66% <2.38%> (-2.43%) ⬇️

@kananb kananb force-pushed the kanan/semantic-validation branch 3 times, most recently from 78dfed1 to 3db9024 Compare August 21, 2023 23:50
@kananb kananb marked this pull request as ready for review August 23, 2023 11:02
@kananb kananb requested a review from tevoinea August 23, 2023 11:02
@kananb kananb force-pushed the kanan/semantic-validation branch from c9082cb to 229f88f Compare August 25, 2023 22:19
@kananb kananb force-pushed the kanan/semantic-validation branch from 2bd5a18 to aaf2054 Compare August 28, 2023 21:59
@kananb kananb merged commit 2a88838 into main Aug 28, 2023
@kananb kananb deleted the kanan/semantic-validation branch August 28, 2023 22:14
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants