This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Handle the case where the secret is not serialized as json #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3223 +/- ##
==========================================
- Coverage 29.54% 29.54% -0.01%
==========================================
Files 332 332
Lines 39195 39197 +2
==========================================
Hits 11582 11582
- Misses 27613 27615 +2
|
AdamL-Microsoft
approved these changes
Jun 23, 2023
mgreisen
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
We were assuming the data stored in keyvault is json but we sometimes store strings as well. When we would attempt to deserialize the string, we'd get an error that it's invalid json.