-
Notifications
You must be signed in to change notification settings - Fork 199
Migrate from winapi to windows-rs #3050
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3050 +/- ##
==========================================
- Coverage 34.68% 32.94% -1.74%
==========================================
Files 302 269 -33
Lines 36923 31289 -5634
==========================================
- Hits 12806 10308 -2498
+ Misses 24117 20981 -3136
|
ac6c1c6 to
685b91b
Compare
|
I've checked coverage output with check-pr, which is the main thing that I would expect to be affected by this change. |
|
Just cloned this repo and tried to build with |
The issue here is that it depends on what level in the repo you build at. If you build |
windows-rsis the newer, Microsoft-supported version of the API bindings;winapihasn't been updated in some time. This allows us to remove some code, aswindows-rsincludes theSym*functions that we had to previously defined ourselves indbghelp.Rather than port the
jobsandcomcode I removed it, as it was unused.The
check_hrandcheck_winapimacros have been replaced by use of.ok()?onBOOLand?onHRESULTwhich now support standard error handling facilities.