Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@Porges
Copy link
Member

@Porges Porges commented Apr 19, 2023

The coverage code is not currently exercised by any test.

  • Add a test to the coverage example so that it can run in PR builds.
  • Specify --all-targets so that example tests are run.
  • Install and use nextest instead of the standard test runner.
    • This will parallelize test runs across binaries so the overall test run is faster.
  • Make sleep duration of agent configurable and reduce it in the test run so that it doesn't wait for 30 seconds.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #3035 (a11f5e8) into main (bd2b109) will increase coverage by 1.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
+ Coverage   29.43%   31.37%   +1.94%     
==========================================
  Files         305      274      -31     
  Lines       36544    30924    -5620     
==========================================
- Hits        10755     9702    -1053     
+ Misses      25789    21222    -4567     
Impacted Files Coverage Δ
src/agent/onefuzz-agent/src/agent.rs 55.81% <100.00%> (ø)
src/agent/onefuzz-agent/src/agent/tests.rs 100.00% <100.00%> (ø)

... and 62 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges force-pushed the add-coverage-basic-test branch 2 times, most recently from 39822d3 to c69a965 Compare April 19, 2023 04:34
@Porges Porges enabled auto-merge (squash) April 19, 2023 05:11
@Porges Porges force-pushed the add-coverage-basic-test branch from c69a965 to 4cff2b1 Compare April 19, 2023 10:45
Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love nextest, we should add it to the devcontainer config as well

@Porges Porges merged commit 6f06b8f into main Apr 19, 2023
@Porges Porges deleted the add-coverage-basic-test branch April 19, 2023 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants