Another fix to the regression parsing

Author: chkeita

src/ApiService/ApiService/onefuzzlib/Reports.cs

@@ -49,20 +49,27 @@ public Reports(ILogTracer log, IContainers containers) {
         return ParseReportOrRegression(blob.ToString(), filePath, reportUrl, expectReports);
     }
 
+    private static T? TryDeserialize<T>(string content) where T : class {
+        try {
+            return JsonSerializer.Deserialize<T>(content, EntityConverter.GetJsonSerializerOptions());
+        } catch (JsonException) {
+            return null;
+        }
+    }
+
     private IReport? ParseReportOrRegression(string content, string? filePath, Uri? reportUrl, bool expectReports = false) {
-        var regressionReport = JsonSerializer.Deserialize<RegressionReport>(content, EntityConverter.GetJsonSerializerOptions());
-        if (regressionReport == null || regressionReport.CrashTestResult == null) {
-            try {
-                var report = JsonSerializer.Deserialize<Report>(content, EntityConverter.GetJsonSerializerOptions());
-                return report != null ? report with { ReportUrl = reportUrl } : report;
-            } catch (JsonException e) {
-                if (expectReports) {
-                    _log.Error($"unable to parse report ({filePath:Tag:FilePath}) as a report or regression - {e}");
-                }
-                return null;
-            }
+        var regressionReport = TryDeserialize<RegressionReport>(content);
+        if (regressionReport != null && regressionReport.CrashTestResult != null) {
+            return regressionReport with { ReportUrl = reportUrl };
+        }
+        var report = TryDeserialize<Report>(content);
+        if (report != null) {
+            return report with { ReportUrl = reportUrl };
         }
-        return regressionReport != null ? regressionReport with { ReportUrl = reportUrl } : regressionReport;
+        if (expectReports) {
+            _log.Error($"unable to parse report ({filePath:Tag:FilePath}) as a report or regression");
+        }
+        return null;
     }
 }