Fix notification logic (#2751)

* Fix notification logic
This bug was preventing the rest of the NewFils logic to proceed if no notification was associated with the container

* build fix

Author: chkeita

src/ApiService/ApiService/onefuzzlib/NotificationOperations.cs

@@ -20,34 +20,31 @@ public NotificationOperations(ILogTracer log, IOnefuzzContext context)
     public async Async.Task NewFiles(Container container, string filename, bool isLastRetryAttempt) {
         var notifications = GetNotifications(container);
         var hasNotifications = await notifications.AnyAsync();
-
-        if (!hasNotifications) {
-            return;
-        }
-
         var reportOrRegression = await _context.Reports.GetReportOrRegression(container, filename, expectReports: hasNotifications);
-        var done = new List<NotificationTemplate>();
-        await foreach (var notification in notifications) {
-            if (done.Contains(notification.Config)) {
-                continue;
-            }
+        if (hasNotifications) {
+            var done = new List<NotificationTemplate>();
+            await foreach (var notification in notifications) {
+                if (done.Contains(notification.Config)) {
+                    continue;
+                }
 
-            done.Add(notification.Config);
+                done.Add(notification.Config);
 
-            if (notification.Config is TeamsTemplate teamsTemplate) {
-                await _context.Teams.NotifyTeams(teamsTemplate, container, filename, reportOrRegression!, notification.NotificationId);
-            }
+                if (notification.Config is TeamsTemplate teamsTemplate) {
+                    await _context.Teams.NotifyTeams(teamsTemplate, container, filename, reportOrRegression!, notification.NotificationId);
+                }
 
-            if (reportOrRegression == null) {
-                continue;
-            }
+                if (reportOrRegression == null) {
+                    continue;
+                }
 
-            if (notification.Config is AdoTemplate adoTemplate) {
-                await _context.Ado.NotifyAdo(adoTemplate, container, filename, reportOrRegression, isLastRetryAttempt, notification.NotificationId);
-            }
+                if (notification.Config is AdoTemplate adoTemplate) {
+                    await _context.Ado.NotifyAdo(adoTemplate, container, filename, reportOrRegression, isLastRetryAttempt, notification.NotificationId);
+                }
 
-            if (notification.Config is GithubIssuesTemplate githubIssuesTemplate) {
-                await _context.GithubIssues.GithubIssue(githubIssuesTemplate, container, filename, reportOrRegression, notification.NotificationId);
+                if (notification.Config is GithubIssuesTemplate githubIssuesTemplate) {
+                    await _context.GithubIssues.GithubIssue(githubIssuesTemplate, container, filename, reportOrRegression, notification.NotificationId);
+                }
             }
         }