address comments

Author: chkeita

src/ApiService/ApiService/onefuzzlib/Extension.cs

@@ -240,7 +240,10 @@ public static VMExtensionWrapper GenevaExtension(AzureLocation region) {
 
         if (pool.Os == Os.Windows && scaleSet.Auth is not null) {
             var auth = await _context.SecretsOperations.GetSecretValue<Authentication>(scaleSet.Auth);
-            var sshKey = auth?.PublicKey.Trim();
+            if (auth is null) {
+                throw new Exception($"unable to retrieve auth: {scaleSet.Auth}");
+            }
+            var sshKey = auth.PublicKey.Trim();
             var sshPath = "$env:ProgramData/ssh/administrators_authorized_keys";
             commands.Add($"Set-Content -Path {sshPath} -Value \"{sshKey}\"");
         }

src/ApiService/ApiService/onefuzzlib/Secrets.cs

@@ -37,14 +37,6 @@ public static (Uri, string) ParseSecretUrl(Uri secretsUrl) {
         return (new Uri(vaultUrl), secretName);
     }
 
-    public virtual async Task<SecretData<T>> StoreSecretData<T>(SecretData<T> secretData) {
-        if (secretData.Secret.IsHIddden) {
-            return secretData;
-        }
-        var kv = await StoreSecret(secretData.Secret);
-        return new SecretData<T>(new SecretAddress<T>(kv));
-    }
-
     public async Task<Uri> StoreSecret(ISecret secret) {
         var secretValue = secret.GetValue();
         var secretName = Guid.NewGuid();