Leaving exception.

nharper285 · nharper285 · commit 2e13f80dcf44 · 2023-08-21T17:04:16.000Z
diff --git a/src/ApiService/ApiService/onefuzzlib/JobResultOperations.cs b/src/ApiService/ApiService/onefuzzlib/JobResultOperations.cs
@@ -76,8 +76,7 @@ private async Async.Task<bool> TryUpdate(Job job, JobResultType resultType, Dict
 
             var r = await Insert(jobResult);
             if (!r.IsOk) {
-                _logTracer.AddHttpStatus(r.ErrorV);
-                _logTracer.LogInformation("failed to insert job result {JobId}", jobResult.JobId);
+                throw new InvalidOperationException($"failed to insert job result {jobResult.JobId}");
             }
             _logTracer.LogInformation("created job result {JobId}", jobResult.JobId);
         } else {
@@ -87,8 +86,7 @@ private async Async.Task<bool> TryUpdate(Job job, JobResultType resultType, Dict
 
             var r = await Update(jobResult);
             if (!r.IsOk) {
-                _logTracer.AddHttpStatus(r.ErrorV);
-                _logTracer.LogInformation("failed to update job result {JobId}", jobResult.JobId);
+                throw new InvalidOperationException($"failed to insert job result {jobResult.JobId}");
             }
             _logTracer.LogInformation("updated job result {JobId}", jobResult.JobId);
         }

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ private async Async.Task<bool> TryUpdate(Job job, JobResultType resultType, Dict`
`76`	`76`
`77`	`77`	`var r = await Insert(jobResult);`
`78`	`78`	`if (!r.IsOk) {`
`79`		`- _logTracer.AddHttpStatus(r.ErrorV);`
`80`		`- _logTracer.LogInformation("failed to insert job result {JobId}", jobResult.JobId);`
	`79`	`+ throw new InvalidOperationException($"failed to insert job result {jobResult.JobId}");`
`81`	`80`	`}`
`82`	`81`	`_logTracer.LogInformation("created job result {JobId}", jobResult.JobId);`
`83`	`82`	`} else {`
`@@ -87,8 +86,7 @@ private async Async.Task<bool> TryUpdate(Job job, JobResultType resultType, Dict`
`87`	`86`
`88`	`87`	`var r = await Update(jobResult);`
`89`	`88`	`if (!r.IsOk) {`
`90`		`- _logTracer.AddHttpStatus(r.ErrorV);`
`91`		`- _logTracer.LogInformation("failed to update job result {JobId}", jobResult.JobId);`
	`89`	`+ throw new InvalidOperationException($"failed to insert job result {jobResult.JobId}");`
`92`	`90`	`}`
`93`	`91`	`_logTracer.LogInformation("updated job result {JobId}", jobResult.JobId);`
`94`	`92`	`}`