Skip to content

Commit b801b60

Browse files
committed
Merge pull request #532 from hoanhtien/FixImportWizardTests
Fix import wizard tests.
2 parents 36eca2f + ea7a590 commit b801b60

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Nodejs/Product/Nodejs/Project/ImportWizard/ImportSettings.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,9 @@ public Task<string> CreateRequestedProjectAsync() {
214214
using (var writer = GetDefaultWriter(projectPath)) {
215215
WriteProjectXml(writer, projectPath, sourcePath, filters, startupFile, excludeNodeModules, out projectGuid);
216216
}
217-
// Log telemetry
218-
NodejsPackage.Instance.TelemetryLogger.ReportEvent(TelemetryEvents.ProjectImported, TelemetryProperties.ProjectGuid, projectGuid.ToString("B"));
217+
if (NodejsPackage.Instance != null) {
218+
NodejsPackage.Instance.TelemetryLogger.ReportEvent(TelemetryEvents.ProjectImported, TelemetryProperties.ProjectGuid, projectGuid.ToString("B"));
219+
}
219220
success = true;
220221
return projectPath;
221222
} finally {

Nodejs/Tests/Core/ImportWizardTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ public void ImportWizardTypeScript() {
303303
AssertUtil.ContainsExactly(proj.Descendants(proj.GetName("TypeScriptCompile")).Select(x => x.Attribute("Include").Value),
304304
"server.ts");
305305

306-
Assert.AreEqual("server.js", proj.Descendant("StartupFile").Value);
306+
Assert.AreEqual("server.ts", proj.Descendant("StartupFile").Value);
307307
}
308308

309309
/// <summary>

0 commit comments

Comments
 (0)