Fix use after delete in deleteStackValue (#13)

acoates-ms · web-flow · commit 980cb60d7911 · 2025-05-02T10:20:27.000-07:00
diff --git a/src/NodeApiJsiRuntime.cpp b/src/NodeApiJsiRuntime.cpp
@@ -2178,6 +2178,7 @@ void NodeApiJsiRuntime::NodeApiRefCountedPointerValue::deleteStackValue(
   CHECK_ELSE_CRASH(value_, "value_ must not be null");
   if (canBeDeletedFromStack_) {
     delete this;
+    return;
   }
 
   if (usedByJsiPointer() && ref_ == nullptr) {

Original file line number	Diff line number	Diff line change
`@@ -2178,6 +2178,7 @@ void NodeApiJsiRuntime::NodeApiRefCountedPointerValue::deleteStackValue(`
`2178`	`2178`	`CHECK_ELSE_CRASH(value_, "value_ must not be null");`
`2179`	`2179`	`if (canBeDeletedFromStack_) {`
`2180`	`2180`	`delete this;`
	`2181`	`+ return;`
`2181`	`2182`	`}`
`2182`	`2183`
`2183`	`2184`	`if (usedByJsiPointer() && ref_ == nullptr) {`