fix: Address David's code review feedback

- Fix Alpine musl detection with glob fallback for /lib/ld-musl*
- Remove shell=True from Windows subprocess call (security)
- Fix version duplication - import __version__ from __init__.py
- Add OSError handling in build_wheel and build_editable
- Sync build_ddbc version to 1.2.0 (matches package)

Author: bewithgaurav

build_ddbc/__init__.py

@@ -15,4 +15,4 @@
 from .compiler import compile_ddbc, get_platform_info
 
 __all__ = ["compile_ddbc", "get_platform_info"]
-__version__ = "1.0.0"
+__version__ = "1.2.0"

build_ddbc/__main__.py

@@ -11,6 +11,7 @@
 import argparse
 import sys
 
+from . import __version__
 from .compiler import compile_ddbc, get_platform_info
 
 
@@ -50,7 +51,7 @@ def main() -> int:
     parser.add_argument(
         "--version", "-V",
         action="version",
-        version="%(prog)s 1.0.0",
+        version=f"%(prog)s {__version__}",
     )
 
     args = parser.parse_args()

build_ddbc/build_backend.py

@@ -73,7 +73,7 @@ def build_wheel(wheel_directory, config_settings=None, metadata_directory=None):
         except FileNotFoundError:
             # If build scripts don't exist, assume pre-compiled binaries
             print("[build_backend] Build scripts not found, assuming pre-compiled binaries")
-        except RuntimeError as e:
+        except (RuntimeError, OSError) as e:
             print(f"[build_backend] Compilation failed: {e}")
             raise
     else:
@@ -119,7 +119,7 @@ def build_editable(wheel_directory, config_settings=None, metadata_directory=Non
         print("[build_backend] Compilation successful!")
     except FileNotFoundError:
         print("[build_backend] Build scripts not found, assuming pre-compiled binaries")
-    except RuntimeError as e:
+    except (RuntimeError, OSError) as e:
         print(f"[build_backend] Compilation failed: {e}")
         raise
 

build_ddbc/compiler.py

@@ -4,6 +4,7 @@
 This module contains the platform detection and build script execution logic.
 """
 
+import glob
 import os
 import platform
 import sys
@@ -40,14 +41,16 @@ def get_platform_info() -> Tuple[str, str]:
     elif sys.platform.startswith("linux"):
         target_arch = os.environ.get("targetArch", platform.machine())
         libc_name, _ = platform.libc_ver()
-        # Empty libc_name could indicate detection failure; default to glibc (manylinux)
+
         if not libc_name:
-            print(
-                "[build_ddbc] Warning: libc detection failed (platform.libc_ver() "
-                "returned an empty name); defaulting to glibc (manylinux) tags.",
-                file=sys.stderr,
-            )
-            is_musl = False
+            # Fallback: check for musl linker (Alpine Linux)
+            # platform.libc_ver() returns empty string on Alpine
+            is_musl = bool(glob.glob("/lib/ld-musl*"))
+            if not is_musl:
+                print(
+                    "[build_ddbc] Warning: libc detection failed; defaulting to glibc.",
+                    file=sys.stderr,
+                )
         else:
             is_musl = "musl" in libc_name.lower()
 
@@ -131,7 +134,6 @@ def _run_windows_build(pybind_dir: Path, arch: str, verbose: bool) -> bool:
     result = subprocess.run(
         cmd,
         cwd=pybind_dir,
-        shell=True,
         check=False,
         capture_output=not verbose,
     )