Commit dc0e162
FIX: Remove unused decimal separator code and add regression tests (#384)
### Work Item / Issue Reference
<!--
IMPORTANT: Please follow the PR template guidelines below.
For mssql-python maintainers: Insert your ADO Work Item ID below (e.g.
AB#37452)
For external contributors: Insert Github Issue number below (e.g. #149)
Only one reference is required - either GitHub issue OR ADO Work Item.
-->
<!-- mssql-python maintainers: ADO Work Item -->
<!-- External contributors: GitHub Issue -->
GitHub Issue: #295
-------------------------------------------------------------------
### Summary
Removes misleading unused decimal-separator code from the bulk fetch
path and adds a regression test to ensure DECIMAL values are parsed
correctly regardless of setDecimalSeparator().
<!--
### PR Title Guide
> For feature requests
FEAT: (short-description)
> For non-feature requests like test case updates, config updates ,
dependency updates etc
CHORE: (short-description)
> For Fix requests
FIX: (short-description)
> For doc update requests
DOC: (short-description)
> For Formatting, indentation, or styling update
STYLE: (short-description)
> For Refactor, without any feature changes
REFACTOR: (short-description)
> For release related changes, without any feature changes
RELEASE: #<RELEASE_VERSION> (short-description)
### Contribution Guidelines
External contributors:
- Create a GitHub issue first:
https://github.com/microsoft/mssql-python/issues/new
- Link the GitHub issue in the "GitHub Issue" section above
- Follow the PR title format and provide a meaningful summary
mssql-python maintainers:
- Create an ADO Work Item following internal processes
- Link the ADO Work Item in the "ADO Work Item" section above
- Follow the PR title format and provide a meaningful summary
-->
---------
Co-authored-by: Gaurav Sharma <sharmag@microsoft.com>1 parent 95e0836 commit dc0e162
File tree
10 files changed
+481
-866
lines changed- mssql_python
- pybind
- tests
10 files changed
+481
-866
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2892 | 2892 | | |
2893 | 2893 | | |
2894 | 2894 | | |
2895 | | - | |
| 2895 | + | |
2896 | 2896 | | |
2897 | 2897 | | |
2898 | 2898 | | |
| |||
3615 | 3615 | | |
3616 | 3616 | | |
3617 | 3617 | | |
3618 | | - | |
| 3618 | + | |
3619 | 3619 | | |
3620 | 3620 | | |
3621 | 3621 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
391 | | - | |
392 | | - | |
| 391 | + | |
393 | 392 | | |
394 | 393 | | |
395 | 394 | | |
| |||
400 | 399 | | |
401 | 400 | | |
402 | 401 | | |
403 | | - | |
404 | | - | |
| 402 | + | |
405 | 403 | | |
406 | 404 | | |
407 | 405 | | |
| |||
469 | 467 | | |
470 | 468 | | |
471 | 469 | | |
472 | | - | |
473 | | - | |
| 470 | + | |
474 | 471 | | |
475 | 472 | | |
476 | 473 | | |
| |||
481 | 478 | | |
482 | 479 | | |
483 | 480 | | |
484 | | - | |
485 | | - | |
| 481 | + | |
486 | 482 | | |
487 | 483 | | |
488 | 484 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
992 | 992 | | |
993 | 993 | | |
994 | 994 | | |
995 | | - | |
996 | | - | |
| 995 | + | |
997 | 996 | | |
998 | 997 | | |
999 | 998 | | |
1000 | 999 | | |
1001 | 1000 | | |
1002 | 1001 | | |
1003 | | - | |
1004 | | - | |
| 1002 | + | |
1005 | 1003 | | |
1006 | 1004 | | |
1007 | 1005 | | |
| |||
2126 | 2124 | | |
2127 | 2125 | | |
2128 | 2126 | | |
2129 | | - | |
2130 | | - | |
| 2127 | + | |
2131 | 2128 | | |
2132 | 2129 | | |
2133 | | - | |
2134 | | - | |
| 2130 | + | |
2135 | 2131 | | |
2136 | 2132 | | |
2137 | 2133 | | |
| |||
0 commit comments