Removing double close

Author: jahnvi480

mssql_python/cursor.py

@@ -16,7 +16,7 @@
 from mssql_python.constants import ConstantsDDBC as ddbc_sql_const
 from mssql_python.helpers import check_error, log
 from mssql_python import ddbc_bindings
-from mssql_python.exceptions import InterfaceError
+from mssql_python.exceptions import InterfaceError, ProgrammingError
 from .row import Row
 
 
@@ -438,7 +438,7 @@ def close(self) -> None:
         Close the cursor now (rather than whenever __del__ is called).
         """
         if self.closed:
-            return
+            raise ProgrammingError("Cursor is already closed.")
 
         if self.hstmt:
             self.hstmt.free()

tests/test_004_cursor.py

@@ -1599,30 +1599,6 @@ def test_cursor_context_manager_enter_returns_self(db_connection):
     # Cursor should be closed after context exit
     assert cursor.closed
 
-def test_double_close(db_connection):
-    """Test that calling cursor.close() multiple times is idempotent and doesn't raise an exception"""
-    try:
-        cursor = db_connection.cursor()
-        
-        # First close() call
-        cursor.close()
-        assert cursor.closed, "Cursor should be closed after first close() call"
-        
-        # Second close() call - should be a no-op and not raise an exception
-        cursor.close()
-        assert cursor.closed, "Cursor should still be closed after second close() call"
-        
-        # Multiple additional close() calls - should also be no-ops
-        cursor.close()
-        cursor.close()
-        assert cursor.closed, "Cursor should remain closed after multiple close() calls"
-        
-    except Exception as e:
-        pytest.fail(f"Multiple cursor.close() calls test failed: {e}")
-    finally:
-        # Create a new cursor for any subsequent tests
-        cursor = db_connection.cursor()
-
 def test_close(db_connection):
     """Test closing the cursor"""
     try: