TDD: tests for index reinstatement issue #14 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
absci
force-pushed
the
dev
branch
2 times, most recently
from
3063141 to
bba825f
Compare
|
Hi @sparrowt, I removed code that causes the index issue. I think those are intended to fix rename model with m2m. So I skipped unit test |
|
Thank you @absci, sorry for the long delay - CLA is now signed and I've rebased onto latest |
sparrowt
force-pushed
the
index-reinstatement-broken
branch
from
3306b54 to
70bcb3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests demonstrate the index reinstatement bugs described on #14
I'm not suggesting this is merged without a fix for that issue (nobody wants tests that always fail!) but I thought having this open as a PR might help with visibility and investigation of the issue.