Added hashing function support #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmah8
commented
Jun 21, 2022
jmah8
commented
- Added support MD5, SHA1, SHA256 and SHA512 for SQL Server 2019 and above
- Throw errors for SHA224, SHA384 and when SQL Server is below 2019
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -305,6 +405,12 @@ | |||
| NthValue.as_microsoft = sqlserver_nth_value | |||
| Round.as_microsoft = sqlserver_round | |||
| Window.as_microsoft = sqlserver_window | |||
| MD5.as_microsoft = sqlserver_md5 | |||
| SHA1.as_microsoft = sqlserver_sha1 | |||
Check failure
Code scanning / devskim
Weak/Broken Hash Algorithm
| 'db_functions.text.test_md5.MD5Tests.test_basic', | ||
| 'db_functions.text.test_md5.MD5Tests.test_transform', | ||
| 'db_functions.text.test_sha1.SHA1Tests.test_basic', | ||
| 'db_functions.text.test_sha1.SHA1Tests.test_transform', |
Check failure
Code scanning / devskim
Weak/Broken Hash Algorithm
| @@ -305,6 +405,12 @@ | |||
| NthValue.as_microsoft = sqlserver_nth_value | |||
| Round.as_microsoft = sqlserver_round | |||
| Window.as_microsoft = sqlserver_window | |||
| MD5.as_microsoft = sqlserver_md5 | |||
Check failure
Code scanning / devskim
Weak/Broken Hash Algorithm
| @@ -9,7 +9,7 @@ | |||
| from django.db.models import BooleanField, CheckConstraint, Value | |||
| from django.db.models.expressions import Case, Exists, Expression, OrderBy, When, Window | |||
| from django.db.models.fields import BinaryField, Field | |||
| from django.db.models.functions import Cast, NthValue | |||
| from django.db.models.functions import Cast, NthValue, MD5, SHA1, SHA224, SHA256, SHA384, SHA512 | |||
Check failure
Code scanning / devskim
Weak/Broken Hash Algorithm
| @@ -9,7 +9,7 @@ | |||
| from django.db.models import BooleanField, CheckConstraint, Value | |||
| from django.db.models.expressions import Case, Exists, Expression, OrderBy, When, Window | |||
| from django.db.models.fields import BinaryField, Field | |||
| from django.db.models.functions import Cast, NthValue | |||
| from django.db.models.functions import Cast, NthValue, MD5, SHA1, SHA224, SHA256, SHA384, SHA512 | |||
Check failure
Code scanning / devskim
Weak/Broken Hash Algorithm
absci
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.