Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP - Add support for scalar types in request bodies #1937

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Oct 31, 2022

  • Validates support for Parsable collections in the request body
  • Adds support for scalar values and collections of scalar values in request body
  • Adds/Refactors tests for PHP method writers

closes #1933
closes #1937

TODO:

@Ndiritu Ndiritu added the PHP label Oct 31, 2022
@Ndiritu Ndiritu self-assigned this Oct 31, 2022
@Ndiritu Ndiritu changed the title Add support for scalar types in request bodies PHP - Add support for scalar types in request bodies Oct 31, 2022
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Any chance you can update the changelog before we merge?

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.0% 87.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PHP is not serializing request bodies that are collections properly
2 participants