Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP - Add support for special characters in query parameters #1584

Merged
merged 9 commits into from
May 24, 2022
Merged

PHP - Add support for special characters in query parameters #1584

merged 9 commits into from
May 24, 2022

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented May 23, 2022 •
edited
Loading

  • creates custom QueryParameter annotation for query parameter attributes
  • updates generation to add QueryParameter annotation to query parameter class attributes
  • adds ParametersNameDecodingHandler to decode special characters plus ParametersNameDecodingOption to configure it

Samples diff - https://github.com/microsoft/kiota-samples/pull/703/files#diff-d7ff77ed23d291848e45a533d9a37715fe75fa208664ebff3a40d69a43c98d67R180

closes #1510

@Ndiritu Ndiritu marked this pull request as draft May 23, 2022 06:20
@Ndiritu Ndiritu marked this pull request as ready for review May 23, 2022 06:32
calebkiage
calebkiage previously approved these changes May 23, 2022
View reviewed changes
@Ndiritu Ndiritu self-assigned this May 24, 2022
@Ndiritu Ndiritu added the PHP label May 24, 2022
baywet
baywet requested changes May 24, 2022
View reviewed changes
src/kiota/Properties/launchSettings.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet baywet enabled auto-merge May 24, 2022 13:35
@baywet baywet merged commit f024939 into main May 24, 2022
@baywet baywet deleted the philip/fix-query-params branch May 24, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@calebkiage calebkiage calebkiage left review comments

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees

@Ndiritu Ndiritu

Labels
PHP
Projects
None yet
Milestone
Complete Graph API Surface support
Development

Successfully merging this pull request may close these issues.

php support for special characters in query parameters
3 participants
@Ndiritu @calebkiage @baywet