Skip to content

CancellationToken is ordered as first parameter in request executor methods #1822

Closed

Description

Changes made via https://github.com/microsoft/kiota/pull/1798/files added the Cancellation compararer to the first of the list. This caused the generated methods in other languages to order the Cancellation as the first optional parameter when it was typically last.

CodeParameterKind.Cancellation => 0,

This may potentially cause issues as the requestConfiguration parameter would preferably be first in other languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

CsharpPull requests that update .net codefixedtype:bugA broken experience

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions