Skip to content

Commit f972713

Browse files
test: Fix disposable scoping.
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
1 parent b34308e commit f972713

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

tests/http/httpClient/RequestAdapterTests.cs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1160,19 +1160,19 @@ public void ConstructorOverloadsWorkCorrectlyForCompatibility()
11601160
var authProvider = new AnonymousAuthenticationProvider();
11611161
var mockParseNodeFactory = new Mock<IParseNodeFactory>();
11621162
var mockSerializationWriterFactory = new Mock<ISerializationWriterFactory>();
1163-
var httpClient = new HttpClient();
1163+
using var httpClient = new HttpClient();
11641164
var observabilityOptions = new ObservabilityOptions();
11651165

11661166
// Act & Assert - Both constructor overloads should work
1167-
var adapter1 = (HttpClientRequestAdapter?)Activator.CreateInstance(
1167+
using var adapter1 = (HttpClientRequestAdapter?)Activator.CreateInstance(
11681168
typeof(HttpClientRequestAdapter),
11691169
authProvider,
11701170
mockParseNodeFactory.Object,
11711171
mockSerializationWriterFactory.Object,
11721172
httpClient,
11731173
observabilityOptions);
11741174

1175-
var adapter2 = (HttpClientRequestAdapter?)Activator.CreateInstance(
1175+
using var adapter2 = (HttpClientRequestAdapter?)Activator.CreateInstance(
11761176
typeof(HttpClientRequestAdapter),
11771177
authProvider,
11781178
mockParseNodeFactory.Object,
@@ -1186,11 +1186,6 @@ public void ConstructorOverloadsWorkCorrectlyForCompatibility()
11861186
Assert.NotNull(adapter2);
11871187
Assert.NotNull(adapter1.SerializationWriterFactory);
11881188
Assert.NotNull(adapter2.SerializationWriterFactory);
1189-
1190-
// Clean up
1191-
adapter1.Dispose();
1192-
adapter2.Dispose();
1193-
httpClient.Dispose();
11941189
}
11951190
}
11961191

0 commit comments

Comments
 (0)