fix: Restore HttpClientRequestAdapter constructor compatibility between .NET 5+ and .NET Standard/Framework

Author: gavinbarron

src/http/httpClient/CompatibilitySuppressions.xml

@@ -1,10 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
 <Suppressions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Microsoft.Kiota.Http.HttpClientLibrary.HttpClientRequestAdapter.#ctor(Microsoft.Kiota.Abstractions.Authentication.IAuthenticationProvider,Microsoft.Kiota.Abstractions.Serialization.IParseNodeFactory,Microsoft.Kiota.Abstractions.Serialization.ISerializationWriterFactory,System.Net.Http.HttpClient,Microsoft.Kiota.Http.HttpClientLibrary.ObservabilityOptions,System.Version)</Target>
-    <Left>lib/netstandard2.1/Microsoft.Kiota.Http.HttpClientLibrary.dll</Left>
-    <Right>lib/net5.0/Microsoft.Kiota.Http.HttpClientLibrary.dll</Right>
-  </Suppression>
 </Suppressions>

src/http/httpClient/HttpClientRequestAdapter.cs

@@ -4,6 +4,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Diagnostics;
 #if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
@@ -40,15 +41,13 @@ public class HttpClientRequestAdapter : IRequestAdapter, IDisposable
         private readonly bool createdClient;
         private readonly ObservabilityOptions obsOptions;
         private readonly ActivitySource activitySource;
-#if !NET5_0_OR_GREATER
-        private readonly Version httpVersion;
-#endif
+        private readonly Version? httpVersion;
 #if NETSTANDARD2_1_OR_GREATER
         private static readonly Version defaultHttpVersion = HttpVersion.Version20;
 #elif NETSTANDARD2_0 || NETFRAMEWORK
         private static readonly Version defaultHttpVersion = HttpVersion.Version11;
 #endif
-#if NET5_0_OR_GREATER
+
         /// <summary>
         /// Initializes a new instance of the <see cref="HttpClientRequestAdapter"/> class.
         /// <param name="authenticationProvider">The authentication provider.</param>
@@ -57,8 +56,15 @@ public class HttpClientRequestAdapter : IRequestAdapter, IDisposable
         /// <param name="httpClient">The native HTTP client.</param>
         /// <param name="observabilityOptions">The observability options.</param>
         /// </summary>
-        public HttpClientRequestAdapter(IAuthenticationProvider authenticationProvider, IParseNodeFactory? parseNodeFactory = null, ISerializationWriterFactory? serializationWriterFactory = null, HttpClient? httpClient = null, ObservabilityOptions? observabilityOptions = null)
-#else
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public HttpClientRequestAdapter(IAuthenticationProvider authenticationProvider, IParseNodeFactory? parseNodeFactory, ISerializationWriterFactory? serializationWriterFactory, HttpClient? httpClient, ObservabilityOptions? observabilityOptions)
+            : this(authenticationProvider, parseNodeFactory, serializationWriterFactory, httpClient, observabilityOptions, httpVersion: null)
+        {
+            // Constructor without HttpVersion for runtime backwards compatibility. Adding a new
+            // optional parameter provides *compile-time* backwards compatibility but throws a
+            // MissingMethodException at runtime.
+        }
+
         /// <summary>
         /// Initializes a new instance of the <see cref="HttpClientRequestAdapter"/> class.
         /// <param name="authenticationProvider">The authentication provider.</param>
@@ -69,7 +75,6 @@ public HttpClientRequestAdapter(IAuthenticationProvider authenticationProvider,
         /// <param name="httpVersion">The HTTP version.</param>
         /// </summary>
         public HttpClientRequestAdapter(IAuthenticationProvider authenticationProvider, IParseNodeFactory? parseNodeFactory = null, ISerializationWriterFactory? serializationWriterFactory = null, HttpClient? httpClient = null, ObservabilityOptions? observabilityOptions = null, Version? httpVersion = null)
-#endif
         {
             authProvider = authenticationProvider ?? throw new ArgumentNullException(nameof(authenticationProvider));
             createdClient = httpClient == null;
@@ -79,7 +84,9 @@ public HttpClientRequestAdapter(IAuthenticationProvider authenticationProvider,
             sWriterFactory = serializationWriterFactory ?? SerializationWriterFactoryRegistry.DefaultInstance;
             obsOptions = observabilityOptions ?? new ObservabilityOptions();
             activitySource = ActivitySourceRegistry.DefaultInstance.GetOrCreateActivitySource(obsOptions.TracerInstrumentationName);
-#if !NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
+            this.httpVersion = httpVersion;
+#else
             this.httpVersion = httpVersion ?? defaultHttpVersion;
 #endif
         }
@@ -620,7 +627,7 @@ private HttpRequestMessage GetRequestMessageFromRequestInformation(RequestInform
                 Method = new HttpMethod(requestInfo.HttpMethod.ToString().ToUpperInvariant()),
                 RequestUri = requestUri,
 #if NET5_0_OR_GREATER
-                Version = client.DefaultRequestVersion,
+                Version = httpVersion ?? client.DefaultRequestVersion,
                 VersionPolicy = client.DefaultVersionPolicy
 #else
                 Version = httpVersion

tests/http/httpClient/RequestAdapterTests.cs

@@ -1149,6 +1149,44 @@ public async Task HttpVersionDefaultShouldBeHttp11()
             Assert.Equal(HttpVersion.Version11, requestMessage.Version);
         }
 #endif
+
+        [Fact]
+        public void ConstructorOverloadsWorkCorrectlyForCompatibility()
+        {
+            // This test verifies the fix for the MissingMethodException issue
+            // when code compiled against netstandard2.1 runs on newer frameworks
+
+            // Arrange - Test the constructor without Version parameter (matches NET5+ signature)
+            var authProvider = new AnonymousAuthenticationProvider();
+            var mockParseNodeFactory = new Mock<IParseNodeFactory>();
+            var mockSerializationWriterFactory = new Mock<ISerializationWriterFactory>();
+            using var httpClient = new HttpClient();
+            var observabilityOptions = new ObservabilityOptions();
+
+            // Act & Assert - Both constructor overloads should work
+            using var adapter1 = (HttpClientRequestAdapter?)Activator.CreateInstance(
+                typeof(HttpClientRequestAdapter),
+                authProvider,
+                mockParseNodeFactory.Object,
+                mockSerializationWriterFactory.Object,
+                httpClient,
+                observabilityOptions);
+
+            using var adapter2 = (HttpClientRequestAdapter?)Activator.CreateInstance(
+                typeof(HttpClientRequestAdapter),
+                authProvider,
+                mockParseNodeFactory.Object,
+                mockSerializationWriterFactory.Object,
+                httpClient,
+                observabilityOptions,
+                new Version(1, 1));
+
+            // Verify both adapters are created successfully
+            Assert.NotNull(adapter1);
+            Assert.NotNull(adapter2);
+            Assert.NotNull(adapter1.SerializationWriterFactory);
+            Assert.NotNull(adapter2.SerializationWriterFactory);
+        }
     }
 
     public enum TestEnum