[0037] Only restrict nesting cbuffer and namespace decls #685
Conversation
This slightly scales back the proposal to restricting namespaces in cbuffers and restricting nesting of cbuffers. This is likely a safe change for HLSL 202x, and we'll consider more significant changes in subsequent language updates.
|
Better if the PR title says what this does ("Only restrict nested namespaces and cbuffers inside of cbuffers") rather than how we decided to do that. Mentioning that this came out of a design meeting is better suited as part of the commit body. |
llvm-beanz
changed the title
| \define{cbuffer-member-declaration}\br | ||
| block-declaration\br | ||
| function-definition\br | ||
| template-declaration\br | ||
| empty-declaration |
There was a problem hiding this comment.
Where did the variable-declaration disappear? And what is block-declaration?
There was a problem hiding this comment.
block-declaration is any declaration that can occur at block scope (i.e. any declaration you could have inside a function). That includes variables, but also aliases, static asserts, and other "simple" declarations like functions and classes.
The draft language spec PR includes some wider changes to the declarations chapter and grammars:
https://github.com/microsoft/hlsl-specs/pull/684/files#diff-11b83f8183acd1a33489925bf65fbeb9d420609588c72b0075263be859f6d186
There was a problem hiding this comment.
Oh I see :) That's why I could not find it in the current version of the spec.
Co-authored-by: Helena Kotas <hekotas@microsoft.com>
3 participants
This slightly scales back the proposal to restricting namespaces in cbuffers and restricting nesting of cbuffers. This is likely a safe change for HLSL 202x, and we'll consider more significant changes in subsequent language updates.
This conclusion came out of the language design meeting discussion from 10/13/2025.
The language spec updates are posted in a draft as #684.