Switch to golangci-lint v2
#2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1 is deprecated, and `golangci/golangci-lint-action@v8` requires v2.1+. Use `golangci-lint migrate` to switch to v2 settings and remove outdated/deprecated settings. Ignore `nil` pointer lints for tests, since the linter doesn't handle `t.Fatal` appropriately. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Various new lint issues, mostly staticcheck quick fixes (via `golangci-ling --fix`): - embedded field selector - simplify conditionals via De Morgan - replace `strings.Replace(_, _, _, -1)` with `strings.ReplaceAll()` - switch `if/else-if` to `switch` - move conditional into infinite `for` loops - omit unnecessary type declaration Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
kiashok
approved these changes
Jun 2, 2025
anmaxvl
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 is deprecated, and
golangci/golangci-lint-action@v8requires v2.1+.Use
golangci-lint migrateto switch to v2 settings and remove outdated/deprecated settings.Ignore
nilpointer lints for tests, since the linter doesn't handlet.Fatalappropriately.Fix various new lint issues, mostly
staticcheckquick fixes (viagolangci-ling --fix):strings.Replace(_, _, _, -1)withstrings.ReplaceAll()if/else-iftoswitchforloopsSee #2427