Use abs path to testing binary #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
force-pushed
the
func-test-abs
branch
from
a295eca to
cad4031
Compare
Use the full path to the `functional.test.exe` binary when sharing into the uVM or container for the `TestHVSock_*` test cases in `test\functional\hvsock_test.go` to prevent vSMB share issues. Otherwise, `os.Args[0]` will return the path that the tests were run with (e.g., `.\functional.test.exe`), which can cause vSMB to fail with `The parameter is incorrect.` (likely because it cannot find the current file). Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
func-test-abs
branch
from
cad4031 to
a5874d7
Compare
jiechen0826
approved these changes
Jan 9, 2025
Contributor
jiechen0826
left a comment
jiechen0826
left a comment
There was a problem hiding this comment.
LGTM. Just one nit comment.
jiechen0826
approved these changes
Jan 9, 2025
yyatmsft
reviewed
Jan 9, 2025
test/functional/hvsock_test.go
Outdated
| // reExecSelfShareUVM shares the current testing binary directly into the specified uVM, | ||
| // | ||
| // This assumes that binary will be run directly on a uVM, and not from within a container. | ||
| // For the later case, see [reExecSelfCmd]. |
Contributor
|
LGTM. |
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
func-test-abs
branch
from
ad24cf4 to
1666f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the full path to the
functional.test.exebinary when sharing into the uVM for theTestHVSock_*test cases intest\functional\hvsock_test.goto prevent vSMB share issues.Otherwise,
os.Args[0]will return the path that the tests were run with (e.g.,.\functional.test.exe), which can cause vSMB to fail withThe parameter is incorrect.(likely because it cannot find the current file).